Meet Landing Page

Community feedback

• 

  Edgar Badillo•215

  @EdgarBadilloPosted over 3 years ago

  Hello nice day.

  I did this challenger 2 weeks ago and you have same mistakes as me.

  --- you have a side scroll (x axis) in all your resolution (mobile, pad, and desktop) is not a big deal but you can resolve this looking for you element wider than others. I found it and is your .header-img. your img has 414px width and your body has 360 px. fix you image and the side scroll will dissapear.

  --i use a main container for all my code (.container) is better that only body.

  -- on .number. maybe you can change to relative to fix you .one. --your div footer, you can use a z--index .9999 to overplace you .div one. because circle is still visible.

  --my mian problem on this challenger was classes name. Try to use a BEM methodology on your next challenges. Is not necesary but will helpyou to have a excelent organization on your classes names.

  Soryy for my english, have a nice day.

  Marked as helpful

  0

  ---

  

  Yuko-code•235

  @Yuko-codePosted over 3 years ago

  @EdgarBadillo thank you for your feedback, I’ll look into them. Great advice I appreciate it!

  0
• 

  eagermonument81•210

  @ixtkPosted over 3 years ago

  You can remove the padding and add display: grid and place-items: center to center the text in the circle. Give the bottom one white background color.

  There's horizontal scrollbar at about 1200px

  Marked as helpful

  0

  ---

  

  Yuko-code•235

  @Yuko-codePosted over 3 years ago

  @ixtk Thank you for the advice this is what I needed :)

  0
• 

  T

  Grace•31,230

  @grace-snowPosted over 3 years ago

  Hi

  It looks like you need to pay closer attention to details of the design like

  • font weights
  • alignment between sections (whole page alignment)
  • font sizes (especially on mobile- buttons are unreadably small)

  Marked as helpful

  0

  ---

  

  T

  Grace•31,230

  @grace-snowPosted over 3 years ago

  Also it’s very important to address the accessibility issues raised in your report. Pay close attention to html semantic structure

  0