3-column preview card component Solution

Community feedback

• 

  Edgar Badillo•215

  @EdgarBadilloPosted over 3 years ago

  Nice jobs.

  My (personals) advice:

  -- Try to use only flexbox on this exercise, because, on ipad resolution, you 3 cards do not fit on your container. (resolution 768 x 1024 px).

  --If you are using <div class="container"> you dont need this div. <div class="parent"> is not a big change but you will use less line.

  --resently, i have been using BEM methodology (BEM — Block Element Modifier is a methodology that helps you to create reusable components and code sharing in front-end development). some people like it another one no, but in my experience this helpme to organice better my classes on css.

  Keep training. Sorry for my english.

  Marked as helpful

  1

  ---

  

  Youssef Ali•35

  @youssefali715Posted over 3 years ago

  @EdgarBadillo Thanks bro!🌹

  0
• 

  dewslyse•3,025

  @dewslysePosted over 3 years ago

  Congrats on your first submission. It is well done.

  Rather than use divs throughout your html, you could use sectioning elements like header, main, footer, etc.

  Wrapping your main content in a main tag will help address accessibility issues.

  Marked as helpful

  1

  ---

  

  Youssef Ali•35

  @youssefali715Posted over 3 years ago

  @dewslyse Thanks for suggestion! 😊

  1
• 

  Ahmed Faisal•5,095

  @afrusselPosted over 3 years ago

  Hi, nice work brother 😊. The way you solve this is good. Responsive view also working well. Just one suggestion, for font-size use rem not px.

  Happy coding

  Marked as helpful

  1

  ---

  

  Youssef Ali•35

  @youssefali715Posted over 3 years ago

  @afrussel Thank you So much 😊

  2