Skip to content
OverviewSolutions
2
Comments
2
DocForLoop
@DocForLoop

All comments

  • Gino Gallardo•50
    @GinoGallardoSubmitted 5 days ago
    What are you most proud of, and what would you do differently next time?

    Me gusto haber practicado css puro sin framewors

    What challenges did you encounter, and how did you overcome them?

    aprender a usar figman

    What specific areas of your project would you like help with?

    al momento de nombrar las clases y los commit

    Pagina hecha unicamente con Html y Css

    2
    DocForLoop•60
    @DocForLoopPosted 3 days ago

    Hi, here are my suggestions :

    • due to GDPR compliance check @font-face rules ,as these font files are in your project.
    • missing hover effects on the card
    • consider using relative CCS units like rem, em, % .. instead px
    • check your margins and paddings in figma files, because there are unnecessary gaps in the layout
    • check clamp() function for font-sizes

    Hope it will help you.

    Marked as helpful
    0
  • DocForLoop•60
    @DocForLoopPosted 5 days ago

    Hi,

    Welcome, I see some issues in your code here are my suggestions:

    • I would use semantic HTML , like main, section, footer
    • I would put every css rules to the separate css file
    • In figma design file there are the correct colors, fonts ,spacings that you can use
    • I would dowload the font files and in css I would use @font-face rules
    • Your h3 element set to display:flex, but it is unnecessary ,because it is not a flex container.

    I hope it will be helpful. All the best!

    Marked as helpful
    0