Skip to content
OverviewSolutions
5
Comments
5
P
DocForLoop
@DocForLoop

All comments

  • DocForLoop•110
    @DocForLoopPosted about 8 hours ago

    Hi, I've checked your code and here are my suggestions:

    • try use picture element for responsive images
    • I don't think you need <br> in h1 it's unnecessary
    • for prices use span element instead of h2, h3
    • try to use @use and @forward rules in scss

    Hope it helps :)

    1
  • DocForLoop•110
    @DocForLoopPosted 3 days ago

    Hi, I see there is a problem with your preview and code links, so I couldn't check it now.

    0
  • DocForLoop•110
    @DocForLoopPosted 9 days ago

    Hi, here are some suggestions:

    • try to use semantic elements like main, article, section, footer
    • I don't think you need media queries
    • try to use :hover and :focus pseudo class selectors to change color and background-color on links

    Hope it helps.

    Marked as helpful
    0
  • Gino Gallardo•100
    @GinoGallardoSubmitted 21 days ago
    What are you most proud of, and what would you do differently next time?

    Me gusto haber practicado css puro sin framewors

    What challenges did you encounter, and how did you overcome them?

    aprender a usar figman

    What specific areas of your project would you like help with?

    al momento de nombrar las clases y los commit

    Pagina hecha unicamente con Html y Css

    2
    DocForLoop•110
    @DocForLoopPosted 20 days ago

    Hi, here are my suggestions :

    • due to GDPR compliance check @font-face rules ,as these font files are in your project.
    • missing hover effects on the card
    • consider using relative CCS units like rem, em, % .. instead px
    • check your margins and paddings in figma files, because there are unnecessary gaps in the layout
    • check clamp() function for font-sizes

    Hope it will help you.

    Marked as helpful
    0
  • DocForLoop•110
    @DocForLoopPosted 22 days ago

    Hi,

    Welcome, I see some issues in your code here are my suggestions:

    • I would use semantic HTML , like main, section, footer
    • I would put every css rules to the separate css file
    • In figma design file there are the correct colors, fonts ,spacings that you can use
    • I would dowload the font files and in css I would use @font-face rules
    • Your h3 element set to display:flex, but it is unnecessary ,because it is not a flex container.

    I hope it will be helpful. All the best!

    Marked as helpful
    0