Skip to content
OverviewSolutions
13
Comments
5
Dmytro
@DmytroTarasiuk

All comments

  • Aleksa Mitrović•150
    @1aleksaSubmitted over 3 years ago

    Is there a way to make it more beautiful?

    I've done the accordion using only css and <details> element. My main issue is that when I click on a new question the previous answers don't collapse (which is quite annoying for me). I've tried using only css without any js for the bonus points. On StackOverflow people answered that they believe that it could be done only by js.

    Essential, for the above-mentioned reason I needed to make a height bigger than usual, which doesn't look nicely when all the answers are collapsed.

    Accordion FAQ fully done by css using element (thanks Grace)

    1
    Dmytro•305
    @DmytroTarasiukPosted over 3 years ago

    Hey. You definitely should use js to make your answers collapse. Alternatively , you can use ':hover' method then it doesn't require a click and answers not gonna collapse. Secondly, website is not responsive on the wide 400px - 800px. Try to add more queries or edit the existing one. Happy codding;)

    Best regards.

    0
  • Jimmy Baradit•175
    @BaraditSubmitted over 3 years ago

    Hi guys! This one was the most challenging at the moment to be honest, took a while but it finally finished! I would love to receive any feedback :) Also I have a question, How can I know the exact font size/padding/margin, etc. of the components? Thanks!

    Fylo Dark Theme using SASS, Flexbox & Grid

    2
    Dmytro•305
    @DmytroTarasiukPosted over 3 years ago

    Hey! In regards to your question: you can find exact styles on the file 'style-guide.md' which you must got while downloading the project starter. By the the way, you did a great job. Keep working!

    Marked as helpful
    0
  • Cristina•360
    @cr1deg0Submitted over 3 years ago

    Hi,

    Another interesting challenge. I'm happy with the result and I've learned to change styles with active states. My mobile solution works well in my browser with developer settings for iPhone, however I've noticed that when I look at the site on my iPhone the share button does not return to the original pale colour once the social menu has been deactivated. Can anyone point out what the issue could be? Thanks, Cristina

    Article preview component with HTML, CSS and JS

    2
    Dmytro•305
    @DmytroTarasiukPosted over 3 years ago

    Hi Cristina, You did an amazing job I really like it. Your solution looks very good on a laptop and mobile. However, it is not a fully responsive as on the wide 376 - 620px some components of your card are out of a page. In addition, it's better to use 'rem', 'em', 'vw', 'vh', '%' units instead of px for media-queries to avoid of re-writing unnecessary code. That's all I've noticed.

    Have a fun coding. Cheers ;)

    0
  • Dmytro•305
    @DmytroTarasiukPosted over 3 years ago

    Hello Damian! Your website looks very good on a laptop version, you did a great job. However, the "swiper-slide testimonial" div with a name of Richard is an out of a page. Also, you should make a website to be responsive because it looks confused on a mobile version. That's all I've noticed. Have a fun coding ;)

    0
  • Talal Qamar•30
    @TalalQamar99Submitted over 3 years ago

    This is my second challenge in two days. I really like working on such challenges because it gives me a chance to apply what I have learned on real world challenges. I am still using basic concepts. Any feedback which would help me improve my skills would be appreciated.

    CSS, CSS Flexbox,HTML

    2
    Dmytro•305
    @DmytroTarasiukPosted over 3 years ago

    Hello Talal! Your card looks pretty good but you also should make it responsive. Have a fun coding ;)

    0