Skip to content
OverviewSolutions
4
Comments
4
Dmitriy Stupin
@DmitriyStupin

All comments

  • Dmitriy Stupin•80
    @DmitriyStupinPosted 10 days ago

    Hi, nice job done. Here are a couple of tips:

    1. For naming classes, I advise you to use the BEM methodology, this will allow you to better structure your code, make it easier to write classes, and also give understanding to other developers when reading your code.
    2. I also advise you to break css styles into parts, that is, not to write everything in one style.css file, but to break them into blocks.
    3. I strongly recommend connecting fonts via the @font-face directive. Your method also has a place to be, but when using it, you access a third-party service, which increases the load on the site.
    4. I see that you tried to reset some browser styles. I recommend using reset.css or normalize.css for this. There are many options on the internet from other developers.
    Marked as helpful
    1
  • Gracia Naimora Samosir•110
    @cia2003Submitted 12 days ago
    What are you most proud of, and what would you do differently next time?

    I learn about custom properties and :root pseudo-class. It helped me to use code effectively.

    What challenges did you encounter, and how did you overcome them?

    It is about how to not redundantly use the color's code and instead utilize custom properties and declaring color's global varible.

    What specific areas of your project would you like help with?

    Do you have sources of how to learn CSS Grid?

    fm-profile-links

    1
    Dmitriy Stupin•80
    @DmitriyStupinPosted 12 days ago

    Well done, well done for using :root to create variables. Here are a couple of tips:

    1. I advise you to read about the BEM methodology in order to improve the structure of the code. Clear BEM naming will allow you to better understand the code, not only for you, but also for other developers.
    2. I would wrap links to social networks in ul, and make them links <a>. From the point of view of semantics, the <button> tag does not imply a transition to another page, so use the <a> tag in this case.
    3. I advise you to set the dimensions of the <img> tag with the width and height attributes directly in the markup.
    4. I recommend connecting fonts via @font-face to improve performance.
    5. I also recommend that you do not use too many nested selectors when styling css. I recommend a maximum of 2 selectors when styling, and generally 1 in a good way.
    Marked as helpful
    0
  • Dmitriy Stupin•80
    @DmitriyStupinPosted 13 days ago

    Hi, I would like to make the following tips:

    1. I recommend wrapping the date in the semantic <time> tag with the datetime attribute.
    2. Connect fonts via @font-face
    3. Read about the BEM methodology, it will help you create a good structure for css.
    0
  • Dmitriy Stupin•80
    @DmitriyStupinPosted 13 days ago

    Hi, I would like to make the following advice:

    1. You should not write styles directly in the html markup, it's better to create a separate styles.css file for this and connect it via the <link> tag to the markup.
    0