Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I learn about custom properties and :root pseudo-class. It helped me to use code effectively.
It is about how to not redundantly use the color's code and instead utilize custom properties and declaring color's global varible.
What specific areas of your project would you like help with?Do you have sources of how to learn CSS Grid?
Community feedback
- @DmitriyStupinPosted 15 days ago
Well done, well done for using :root to create variables. Here are a couple of tips:
- I advise you to read about the BEM methodology in order to improve the structure of the code. Clear BEM naming will allow you to better understand the code, not only for you, but also for other developers.
- I would wrap links to social networks in ul, and make them links <a>. From the point of view of semantics, the <button> tag does not imply a transition to another page, so use the <a> tag in this case.
- I advise you to set the dimensions of the <img> tag with the width and height attributes directly in the markup.
- I recommend connecting fonts via @font-face to improve performance.
- I also recommend that you do not use too many nested selectors when styling css. I recommend a maximum of 2 selectors when styling, and generally 1 in a good way.
Marked as helpful0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord