Taishi Arai• 20
@tailorthecreator
Submitted
Hi guys, this is the second solution to the project that I have participated at Front End Mentor in. I gotta say, I am falling in love with the whole process of learning.
Dimitar Pavlov
@DimiPavlov
All comments
- Dimitar Pavlov• 310
@DimiPavlov
Posted
Hello Taishi, congratulations on completing the challenge!!!
I have noticed that you haven't implemented the active state. You can add a hover effect on each of the buttons(including cursor, border, and color). For more information please refer to the active-states.jpg file in the design folder.
Hope I was able to help you.
Happy coding!!!
Marked as helpful
0 - Abdullah Qaasim• 150
@Bidex-03
Submitted
Centering a div
Dimitar Pavlov• 310@DimiPavlov
Posted
Hi Abdullah
Congratulation on completing the challenge.
In regards to your difficulty to center the component, I notice that you tried to apply the CSS for centering on the div with id: 'container' where you should apply them on the body.
Maybe try to add those styles to your body CSS: height: 100vh; display: flex; justify-content: center; align-items: center;
And remove the one from the div with id: 'container'
I hope I was able to help you.
Happy coding!!!
0 - Ahmed Osama• 20
@androidbasha572
Submitted
align items was a little bit difficult Note: This is my first challenge
Dimitar Pavlov• 310@DimiPavlov
Posted
Hello Ahmed
First of all congratulation on completing the challenge. I have noticed a couple of things.
- I do believe that you forgot the add the hover effect on the main picture, name, and 'Equilibrium'. Please refer to the 'active-states.jpg' in the design folder.
- Apply some margin for avatar and text, and <hr> and footer.
- Think about adding some semantic HTML elements. You can read below all the benefits.
https://www.freecodecamp.org/news/semantic-html5-elements/
Hope I was able to help you.
Happy coding!!!
Marked as helpful
1 - Garang Deng• 190
@garang-deng
Submitted
I love how I'm improving lately👌😍 but how some things just don't work out is so frustrating and irritating 😒😢
Why doesn't my "color: inherit;" works? I'll really appreciate any help from you guys, much thanks.
Dimitar Pavlov• 310@DimiPavlov
Posted
Hello Garang, congratulation on completing the challenge.
Regards your question about color: inherit not working, I suggest you take a look at the MDN site about the 'inherit' property.
https://developer.mozilla.org/en-US/docs/Web/CSS/inherit
It does inherit the color of the parent element, in your case, that's the sections. If you take a look at your code, you will see that your section has no color property, only a background-color. So you are trying to inherit a color from a background-color, which is not possible. You can add a random color to your sections and see how your button color will also inherit it.
Hope I was able to help you.
Happy coding :)
Marked as helpful
0 - Erycah Jules• 20
@EJdevgithub
Submitted
For me the hardest part the hover effect when the cursor hover over the buttons... i dont why its not working...so if you have suggestion on how to solve
Dimitar Pavlov• 310@DimiPavlov
Posted
Hi Erycah, well done on completing the challenge.
In order to achieve the change of background color on hover effect, try to set it to transparent.
background-color: transparent;
Happy coding!!!
0 - Mahdi Aljaza'iri• 250
@MahdiAljazairi
Submitted
What do you think about what I did in the creator name section?
Dimitar Pavlov• 310@DimiPavlov
Posted
Hello Mahdi, seems like the "Preview Site" option for your project is not working.
Not Found - Request ID: 01G788R3CVP3BZFJWC38NPX6SH
Github also returns 404.
1 - BreinerJT• 530
@BreinerJT
Submitted
This challenge took me a while because I don't know much about async / await functions, I don't feel good about my knowledge in this kind of functions so if you know where can I learn or read more about this I would really appreciate it if you share it with me. Any feedback is welcome!
Dimitar Pavlov• 310@DimiPavlov
Posted
Hello BreinerJT and congratulations on completing the challenge.
I really like your idea of switching the colors of the charts, looks very cool. Just a small suggestion for a better user experience is maybe to add 'cursor: pointer' for the hover effect.
Marked as helpful
0 - Alan Leonel Torres• 210
@DevFelt
Submitted
Dimitar Pavlov• 310@DimiPavlov
Posted
Hello Alan, first of all well done on completing the challenge.
I notice that you haven't added any of the hover effects, for the main image, the name, and the amount of ETH. Please use the active-states picture in the design folder for reference.
Marked as helpful
0 - Nino Tsitsriashvili• 110
@NinoTsitsriashvili
Submitted
Dimitar Pavlov• 310@DimiPavlov
Posted
Hello Nino, congratulations on completing the challenge.
I have noticed that you added cursor: pointer on hovering the main image, but you haven't included the background color and the icon.
0 - Olaegbe Abdul-Rahmon• 110
@Youngtechie
Submitted
Any changes to make?
Dimitar Pavlov• 310@DimiPavlov
Posted
Hello Olaegbe, well done completing the challenge. Maybe you can make some small overall cosmetic changes:
- add some padding to your main component.
- days of the week color seems to be different.
- include some extra margin in between the elements.
- add 'cursor: pointer' when hovering over the charts, it will increase the user experience.
I love how you have added the GitHub link inside the component, looks really nice.
1 - franklin okika• 40
@franklinscripts
Submitted
The difficult part building this project was the API part, because I literally knew nothing about API so I had to learn it step-by-step to implement it
I am not too sure I understand what's going on but I did it 🚀
Dimitar Pavlov• 310@DimiPavlov
Posted
Hello Franklin and well done completing the challenge. The functionality looks great however, the design part looks a bit off. Maybe you can try and have another look in the 'design' folder, where you will find all .jpg files and compare them with yours.
1 - Lucas Lago• 10
@lucasslago1
Submitted
Dimitar Pavlov• 310@DimiPavlov
Posted
Hi Lucas and well done!!!
Few small suggestions:
- You haven't added the view icon on hover, the main picture.
- For better user experience maybe you can add "cursor: pointer" on hovering the main picture, the same as you did with "Equilibrium" and "Jules Wyvern"
Marked as helpful
0
