Dharmik_487

Latest comments

• 

  Daniel•60

  @danpthSubmitted over 3 years ago

  

  Responsive page with Grid, Flexbox and Javascript

  3

  10
  

  Dharmik_487•1,740

  @Dharmik48Posted over 3 years ago

  Hey👋,

  Good job with the solution! Looks nice, I just have a couple of things I think you can improve:

  • At around 930px screen width, the form looks very thin, so I think you should increase the width a bit.
  • Also it would be good if you add transition on hover state.

  Keep Developing👍

  0
• 

  Sammy•280

  @soyedSubmitted over 3 years ago

  

  Ping Coming Soon page - 7 / 10 🥳

  1

  10
  

  Dharmik_487•1,740

  @Dharmik48Posted over 3 years ago

  Hey👋,

  Your solution looks pretty good! I just have a couple of suggestions:

  • Firstly, there is a vertical scroll bar in your solution and I don't think it should be there.
  • And I suggest you to remove the default outline on focus state from buttons and links.

  Apart from these you solution looks nice, keep it up👍

  Marked as helpful

  1
• 

  CoderPr0•645

  @CoderPr0Submitted over 3 years ago

  

  Time-tracking-dashboard

  1

  30
  

  Dharmik_487•1,740

  @Dharmik48Posted over 3 years ago

  Hey👋,

  Good job on completing the challenge! I just have one suggestion for you:

  • Try to use relative units like em and rem more instead of px as it is a good practice and helps in responsive design as well!

  Keep Developing👍

  Marked as helpful

  1
• 

  Ali Sbane•470

  @0x41-liSubmitted over 3 years ago

  

  Built with mobile-first flow, Postcss, Flexbox, Grid and Sass.

  1

  10
  

  Dharmik_487•1,740

  @Dharmik48Posted over 3 years ago

  Hey👋,

  Great job with the solution! Looks great, but.. I just have one suggestion for you:

  • Try to use relative units like em and rem more instead of px.

  Keep Developing👍

  Marked as helpful

  0
• 

  Andrew•260

  @andy-devsSubmitted over 3 years ago

  

  Simple Accordion Card with JavaScript

  1

  20
  

  Dharmik_487•1,740

  @Dharmik48Posted over 3 years ago

  Hey👋,

  Your solution is really good! But.. I found a few suggestions:

  • Try to use semantic html tags like main, section, header, etc. more as it is a good practice and good for SEO.
  • Also, I think you should remove the margin-top: 10rem; from 886px media-query as because of it there is a vertical scrollbar.

  Keep it Up👍

  Marked as helpful

  0
• 

  Jonathan•295

  @Nathan-FrontSubmitted over 3 years ago

  

  Book mark landing page

  1

  10
  

  Dharmik_487•1,740

  @Dharmik48Posted over 3 years ago

  Hey👋,

  Your solution looks good, but.. I have a few suggestions:

  • In the features section, when I try to click on the other feature, the details below won't change. So try to add it.
  • Also it would be great if you add some transition to hover state.

  Marked as helpful

  0