Responsive page with Grid, Flexbox and Javascript

Community feedback

• 

  P

  James•85

  @NaetharuCodesPosted about 3 years ago

  Looking at the JS for validation, you have a monster of nested if/else clauses.

  I would try and avoid this if possible.

  For doing the validation, you don't really need to do it all in one big clause like that. You could just break it down and run one simple clause for each part.

  That way it will be much easier to read, and much easier to maintain should you come back to this.

  0
• 

  Matias•170

  @MatiasEmilianoPosted about 3 years ago

  Hi, Daniel: Good job! Works well, but a few comments:

  • The form isn´t in the middle of the screen (Verticaly).

  • When the validation is wrong and "Wrong Name" "Wrong email" ...etc apears, the form grows verticaly and don´t look good!

  Hope you can improve! By! Keep Developing!

  0

  ---

  

  P

  James•85

  @NaetharuCodesPosted about 3 years ago

  @MatiasEmiliano

  The vertical growth is part of the design I think. The Figma shows it doing this. I agree it looks weird. But it is correct.

  0
• 

  Dharmik_487•1,740

  @Dharmik48Posted about 3 years ago

  Hey👋,

  Good job with the solution! Looks nice, I just have a couple of things I think you can improve:

  • At around 930px screen width, the form looks very thin, so I think you should increase the width a bit.
  • Also it would be good if you add transition on hover state.

  Keep Developing👍

  0