Skip to content
Submitted about 3 years ago

Simple Accordion Card with JavaScript

Andrew•260
@andy-devs
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...FAQ accordion card
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

My first attempt to make an accordion. Looking forward to hear your advice :)

Community feedback

  • Dharmik_487•1,740
    @Dharmik48Posted about 3 years ago

    Hey👋,

    Your solution is really good! But.. I found a few suggestions:

    • Try to use semantic html tags like main, section, header, etc. more as it is a good practice and good for SEO.
    • Also, I think you should remove the margin-top: 10rem; from 886px media-query as because of it there is a vertical scrollbar.

    Keep it Up👍

    Marked as helpful
    0
    Andrew•260
    @andy-devsPosted about 3 years ago

    @Dharmik48 Thanks! Appreciate your advice

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord