Daniele Ercoli

Latest comments

• 

  Jackson-zablon15•250

  @Jackson-zablon15Submitted about 1 month ago

  What are you most proud of, and what would you do differently next time?

  I'm proud of doing the email verification using vanila js. Next time i will use third party like validatorjs.

  What challenges did you encounter, and how did you overcome them?

  Some of the challenges i encountered was when dismiss success page, the email was still on input field because i just changed the display property of pages. I decided the button should reload the page not change the display property

  What specific areas of your project would you like help with?

  I would like help in following areas

  1. Working on mobile version, the top image was clipped i don't why mostly it occurs when i set align-items to center but even when i removed it nothing changed.

  2. On switching the pages when success validation, i wanted to use classList but i found it didn't work efficiently so i decided to write the style directly.

  3. Setting the height of container(the whole content) and body given the desktop and mobile design have different sizes. Mostly i set the body and container height on desktop and mobile separately using @media but i don't think it is good practice

  

  Newspaper signup with success card

  1

  00
  

  Daniele Ercoli•170

  @DanieleErcoli243Posted about 1 month ago

  Hi. I took a look at the page. The validation works properly, well done, but the message exploded when I got there. I used Javascript to write the error message according to the error, but you followed the reference so I don't think that it's a mistake. I tried the different breakpoints, but If you saved some work I'm proud of you.

  1
• 

  omar khaled•160

  @okhaled11Submitted about 2 months ago

  What specific areas of your project would you like help with?

  Hi Guys 😊 I need some help regarding responsive screens. 📱💻 How can I improve the size of the main container on screens between large and small sizes so that it adapts properly to fit the screen dimensions? 🔧✨

  

  Stats Preview Card

  1

  21
  

  Daniele Ercoli•170

  @DanieleErcoli243Posted about 2 months ago

  Hi. I've been reading your CSS, focusing on media queries. I read that you set two media queries for 600 px and 601 px. I've been taught to follow Bootstrap breakpoints (https://getbootstrap.com/docs/5.0/layout/breakpoints/), in order to work on realistic widths for all devices. In order to adapt containers I give a max-width in px and then margin: 0 auto; according to the viewport. Anyway you'd better not work on the main itself, instead create a div and use it as a container inside the main and then create an other div to use as the card. Or at least I've been taught to do so and it works. I hope that this is useful for you. Best wishes.

  Marked as helpful

  1
• 

  P

  Makc240305•130

  @Makc240305Submitted 2 months ago

  

  Article-preview-component

  1

  20
  

  Daniele Ercoli•170

  @DanieleErcoli243Posted 2 months ago

  The site looks perfect. It works and it's responsive. You've used the toggle property to show the box with the links, which is really smart. I should have thought about it. I can't read some of the things you wrote in css, maybe because I don't know them. Anyway classes in HTML and CSS selectors should be kebab case. You did a very good job.

  0
• 

  breno belchior de freitas gomes•80

  @belchiorgomesSubmitted 2 months ago

  

  Seção de grade de depoimentos

  1

  40
  

  Daniele Ercoli•170

  @DanieleErcoli243Posted 2 months ago

  Hi. The first thing I noticed is that the cards are huge in the largest breakpoint, but then they are responsive, so good job. Maybe I would have used different tags for the names of the testimonials. As for CSS, I've never used Grid, but I guess you used it properly, because it works.

  0
• 

  LeoNard•50

  @succxesSubmitted 3 months ago

  

  four-card-feature-section

  1

  20
  

  Daniele Ercoli•170

  @DanieleErcoli243Posted 3 months ago

  Hi. I read the code and actually the HTML is semantic. I liked the use of the header tag for the upper part of the page, but I've been taught no to use many h1. A page should have just one h1 and then the other headings are supposed to go from h2. I really envy the use of root properties. I saw that the padding between the cards is not regular. You'd better use a system of row and cols, giving some padding to the cols and a negative margin to the row.

  0
• 

  Rounak Kumar Singh•110

  @rounakkumarsinghSubmitted 3 months ago

  What are you most proud of, and what would you do differently next time?

  • I learnt Tailwind CSS and making a good directory structure.
  • I would also implement the media queries using tailwindcss too.

  What challenges did you encounter, and how did you overcome them?

  • Using TailwindCSS came to me as a challenge.
  • Making a production copy of CSS and deploying it.

  

  Responsive Product Preview Card using Tailwind CSS

  1

  50
  

  Daniele Ercoli•170

  @DanieleErcoli243Posted 3 months ago

  The link to the code brings to a 404 not found page of github, so I actually can't read the code nor comment it. The project looks really good at the smallest breakpoint, but at the larger one the picture is smaller than the product description.

  0