Skip to content
OverviewSolutions
4
Comments
4
CecDor
@CecDorWEB

All comments

  • Rubens Carvalho•80
    @RubensTMSubmitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    Nada, tudo de boa

    What challenges did you encounter, and how did you overcome them?

    Nenhum

    What specific areas of your project would you like help with?

    Nenhum

    Opa

    1
    CecDor•60
    @CecDorWEBPosted 4 months ago

    Hello, good job !

    I have a few subjection:

    • To list the instructions, you need to use an ordonnate list (ol) not unordonate list (ul).
    • Use english words to called your class.
    • Learn to use contraction for your margin, padding: example: margin: 30px; margin-left: 50px; margin-top: 50px; = It's the same as: margin : 50px 30px 50px 30px;
    • Prefer use em instead of px.
    0
  • CecDor•60
    @CecDorWEBPosted 4 months ago

    Hello, Congratulations for this excellent result !

    When I read your code I think:

    • Lot's of DIV, maybe prioritize HTML tag
    • Lot's of scss files, so it's difficult and very time-consumming to review your code. I understand your orzanisation but, for a small project it is not very practical.

    You seem to be expert to scss, with mixin, variable... so it was interesting for me to look at your code.

    0
  • CecDor•60
    @CecDorWEBPosted 4 months ago

    Hello,

    I watched your code, your design is good, but maybe can you be careful about:

    HTML:

    • You use a lot's of DIV. It isn't a very good practice because a DIV it's an empty element for the navigator. Prefer to use HTML tag, there are better read by navigator (for SEO). For exemple, for your container, you can use a tag <article>. And in your article you can use the balise <section> for description section or author section. Use DIV only when you cannot use Html tag.

    • You can style tag HTML directly without DIV around. For example, the DIV around the first <img> is not necessary.

    • The sentence "HTML & CSS foundations" it is not a <p> it's a Title. So use HTML tags <H1>, <H2><,<H3>...

    CSS:

    • Variables should not be called by their color. Because by definition a variable can change. So maybe now your main color is Yellow but maybe you will need to change it for purple color. So it will be strange to have a variable called "Yellow" with purple property. So you should use a general name, maybe like "primary_color", "font_light_color"...

    Good luck and good learning !

    0
  • Eugene Clark•50
    @clarkjr2016Submitted 5 months ago
    What are you most proud of, and what would you do differently next time?

    I am most proud of downloading and learning SASS to build this application. I am also proud of myself for relearning git/github. Finally, I'm proud of myself for attempting to follow the workflow that front end mentors suggested. It's given me a systematic way to approach front end development.

    I would be more strict with the application of the workflow.

    What challenges did you encounter, and how did you overcome them?

    The challenge that I face is my own frustration that I feel when things aren't "pixel perfect". I also faced a challenge of installing SASS. I struggled to utilize it when installing it in my Windows PATH, but I switched to using the "Live SASS Compiler" extension on VS code.

    What specific areas of your project would you like help with?

    I would like help with project management. I would like help in better developing workflows to systematically complete projects.

    Separations of Concerns (HTML & CSS)

    1
    CecDor•60
    @CecDorWEBPosted 5 months ago

    Hello, Congratulations on your solution !

    Things you could improve ✍️:

    • Use the font indicated in the style guide with the link to go to the web site. It's possible to use <link> or @import to retrieve the font.
    • Try using semantic HTML elements like main, section and article.
    • I suggest using clear descriptive CSS classes like .card, .card-title and .card-description.

    Happy coding! 😎

    Marked as helpful
    1