html ,css with sass

Community feedback

• 

  CecDor•60

  @CecDorWEBPosted 4 months ago

  Hello,

  I watched your code, your design is good, but maybe can you be careful about:

  HTML:

  • You use a lot's of DIV. It isn't a very good practice because a DIV it's an empty element for the navigator. Prefer to use HTML tag, there are better read by navigator (for SEO). For exemple, for your container, you can use a tag <article>. And in your article you can use the balise <section> for description section or author section. Use DIV only when you cannot use Html tag.

  • You can style tag HTML directly without DIV around. For example, the DIV around the first <img> is not necessary.

  • The sentence "HTML & CSS foundations" it is not a <p> it's a Title. So use HTML tags <H1>, <H2><,<H3>...

  CSS:

  • Variables should not be called by their color. Because by definition a variable can change. So maybe now your main color is Yellow but maybe you will need to change it for purple color. So it will be strange to have a variable called "Yellow" with purple property. So you should use a general name, maybe like "primary_color", "font_light_color"...

  Good luck and good learning !

  0
• 

  Fatima Abid•110

  @fatemzhPosted 4 months ago

  Looks nice, could be improved by adding hovers for the link

  0