@SwapnilTSakhareSubmitted 10 months ago
CalebWhorton12
@CalebWhorton12All comments
- @CalebWhorton12Posted 10 months ago
Congratulations on completing the QR code project!
My only suggestions for improvement would be to make use of Semantic HTML by adding tags such as <main> and <footer> to improve the structure and accessibility of your code.
Despite these few improvements your solution works very well and it's clear you put a lot of effort into it!
Keep up the great work!
Marked as helpful0 - @lkBangarSubmitted 10 months ago
What did you find difficult while building the project? The difficult part was to add padding and margin pixels to make the design similar to the given design images. It would have been much easier if those instructions were also given in the ReadMe.md file.
Which areas of your code are you unsure of? I doubt the media query that I used, as I used flex-box which inherits responsive behaviour, but I have a few doubts regarding the responsiveness.
@CalebWhorton12Posted 10 months agoCongratulations on completing the QR code project!
My only suggestions for improvement would be to make use of Semantic HTML by adding tags such as <main> and <footer> to improve the structure and accessibility of your code.
External CSS: Moving your styles into a CSS file instead of the head. This helps your code read cleaner and easier to maintain.
Despite these few improvements your solution works very well and it's clear you put a lot of effort into it!
Keep up the great work!
Marked as helpful0
