Design comparison
Community feedback
- @Ezekiel225Posted 9 months ago
Hello there π @SwapnilTSakhare.
Good job on completing the challenge !
Your project looks really good!
I have suggestions about your code that might interest you.
Consider changing the background-color of the body element to hsl(212, 45%, 89%).
body { background-color: hsl(212, 45%, 89%); min-height: 100vh; justify-content: center; align-items: center; }
Consider changing the h1 tag to h5 or h6 so as to match the original design.
Try also to reduce the width of the image
I hope it helps!
Other than that, great job!
Happy coding.
Marked as helpful0 - @CalebWhorton12Posted 9 months ago
Congratulations on completing the QR code project!
My only suggestions for improvement would be to make use of Semantic HTML by adding tags such as <main> and <footer> to improve the structure and accessibility of your code.
Despite these few improvements your solution works very well and it's clear you put a lot of effort into it!
Keep up the great work!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord