Bshy201
@Bshy201All comments
- @juriyaSubmitted 2 months ago@Bshy201Posted 2 months ago
I really like how you separated your CSS files. You use semantic HTML well. Excellent solution. The only thing I would fix is the spacing on the top and bottom, but other than that you are good!
1 - @florinmarescuSubmitted 2 months ago@Bshy201Posted 2 months ago
Good job! If I had to make some suggestions, it would to use a main tag instead of the "main-container" class as this would be using more semantic HTML. And one more tip that I was given was to not use position: absolute as it can make layout harder to manage. The solution that someone gave me is:
body { display: flex; justify-content: center; flex-direction: column; } main { width: auto; height: auto; display: inline-block; margin-inline: auto; }
margin-inlin: auto;
is more precise.Hope that helps. Happy learning!
Marked as helpful0 - @Joliot-TSIMISARAKASubmitted 2 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud I've successfully finished this project. It was a real challenge as it forces you to look backward and reinforce your foundations. Having experienced the practicability of flexbox, I'm planning to master it alongside its rival, the grid system
What challenges did you encounter, and how did you overcome them?I wasted quite a bit of time planning the layout of the card and how to go about it. I finally decided to use flexbox with every container inside the card, as long as they have inside items to be aligned.
What specific areas of your project would you like help with?The part about media query and responsive design best practices, using relative units, are still a real challenge for me
@Bshy201Posted 2 months agoThe best way to test out how media queries and relatives units is to just put them in your code and see what happens. For responsive design, follow a tutorial on Youtube, and you'll figure it out in no time. Keep up the good work!
Marked as helpful1 - @Ha0n9Submitted 3 months ago