All comments

• 

  luubelmiro• 90

  @LUANABELMIRO

  Submitted over 1 year ago

  Dica: se a imagem der bug no git, tente com link direcionando para imagem.

  #Obrigado(a) por visualizar! Deixe um <3

  

  Cartão interativo com HTML, CSS e JS

  1

  51

  

  Brijen Makwana• 160

  @BrijenMakwana

  Posted over 1 year ago

  Você pode mudar o nome da função thanks(event) para algo como changeView ou showRating. Seria bom seguir os princípios de código limpo. E você pode seguir as mesmas regras de nomenclatura para estilos e variáveis. Ótimo trabalho.

  1
• 

  Katherine Barrios• 10

  @kbarriosgit

  Submitted over 1 year ago

  Challenge finished, ready for feedback.

  

  qr-component

  2

  30

  

  Brijen Makwana• 160

  @BrijenMakwana

  Posted over 1 year ago

  Really well done. Try to use em or px for width, padding. Don't use rem for that, use rem for fonts only.

  Wish you luck.

  1
• 

  Mahek Rohit Gor• 10

  @MahekRohitGor

  Submitted over 1 year ago

  

  QR Code Component

  1

  20

  

  Brijen Makwana• 160

  @BrijenMakwana

  Posted over 1 year ago

  Hey Mahek,

  Good attempt first of all. You can give border-radius of the image in px, because as you can see it's not affecting much on the top side of the image.

  And this is a really small example, so you don't need to provide multiple classes for tags. It'll crate confusion for the others. And since there is no javascript involved, you don't need to use id and class both for the tags.

  I wish you all the best.

  0
• 

  OPARA GOODNESS• 10

  @imosfinest

  Submitted almost 2 years ago

  Hello community, not sure if I completed this project perfectly. Please let me know what I should have done better. My first challenge was centering my container, not sure if I did that well..

  

  QR-code-component using html and css.

  2

  20

  

  Brijen Makwana• 160

  @BrijenMakwana

  Posted almost 2 years ago

  Hey OPARA GOODNESS. Very good. My suggestion is to provide height and width of the images in the css file.

  0

  This comment has received 1 replyShow
• 

  Valarie Oyieke• 60

  @ValarieOyieke

  Submitted almost 2 years ago

  I wasn't able to align the div with the prices at the center with display: flex; align-items: center; so I used align-items: baseline instead.

  Any help on what might have caused it not to work will be highly appreciated.

  

  Product preview card with Html and CSS

  3

  40

  

  Brijen Makwana• 160

  @BrijenMakwana

  Posted almost 2 years ago

  Hey Valarie Oyieke, very nice. One suggestion from me is that to centre the .wrapper class, you can apply following styling.

  margin-left:auto;
  margin-right:auto;
  

  Good luck for the next challenges.

  0

  This comment has received 1 replyShow