QR-code-component using html and css.

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hello Opara, You have done a good work! 😁

  Some little tips to improve your code:

  • use main tag to wrap the card and improve the Accessibility but not as a container of that one element
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the header container of image
  • not use <br> to make space but use margin property... br tag is for break line of text and it have a semnantic meaning
  • remove all margin from .QRcode class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  0

  ---

  

  OPARA GOODNESS•10

  @imosfinestPosted almost 2 years ago

  @denielden Thank you so much.. I truly appreciate your quick response... will add up your suggestion and wait your response again....Thank you.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @imosfinest You are welcome and keep it up :)

  0
• 

  Brijen Makwana•160

  @BrijenMakwanaPosted about 2 years ago

  Hey OPARA GOODNESS. Very good. My suggestion is to provide height and width of the images in the css file.

  0

  ---

  

  OPARA GOODNESS•10

  @imosfinestPosted almost 2 years ago

  @BrijenMakwana Thank you so much...I will look through and make necessary corrections...Thank you for responding to me.

  0