Design comparison
Solution retrospective
Hello community, not sure if I completed this project perfectly. Please let me know what I should have done better. My first challenge was centering my container, not sure if I did that well..
Community feedback
- @denieldenPosted almost 2 years ago
Hello Opara, You have done a good work! π
Some little tips to improve your code:
- use
main
tag to wrap the card and improve the Accessibility but not as a container of that one element - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - remove all unnecessary code, the less you write the better as well as being clearer: for example the
header
container of image - not use
<br>
to make space but usemargin
property... br tag is for break line of text and it have a semnantic meaning - remove all
margin
from.QRcode
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help π and Happy coding!
Marked as helpful0@imosfinestPosted almost 2 years ago@denielden Thank you so much.. I truly appreciate your quick response... will add up your suggestion and wait your response again....Thank you.
1@denieldenPosted almost 2 years ago@imosfinest You are welcome and keep it up :)
0 - use
- @BrijenMakwanaPosted almost 2 years ago
Hey OPARA GOODNESS. Very good. My suggestion is to provide
height
andwidth
of the images in the css file.0@imosfinestPosted almost 2 years ago@BrijenMakwana Thank you so much...I will look through and make necessary corrections...Thank you for responding to me.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord