qr-component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <h2> with <h1> to fix the accessibility issue.

  There is no need to give the html a max-width value, reduce the value of the font-size to 0.9375rem which is 15px this will be the font-size for both h1 and p, there is no need to give them a font-size after this.

  To center .container on the page using flexbox, add justify-content: centerto the main and remove the margin value from .container.

  Give the img a max-width of 100% instead of a width and add margin value for all the sides to .description. give h1 a margin-bottom value for the space between the text.

  Use the colors that were given in the styleguide.md found in the zip folder you downloaded.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1
• 

  Brijen Makwana•160

  @BrijenMakwanaPosted almost 2 years ago

  Really well done. Try to use em or px for width, padding. Don't use rem for that, use rem for fonts only.

  Wish you luck.

  1