Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr-component

@kbarriosgit

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Challenge finished, ready for feedback.

Community feedback

Hassia Issah 50,670

@Hassiai

Posted

Replace <h2> with <h1> to fix the accessibility issue.

There is no need to give the html a max-width value, reduce the value of the font-size to 0.9375rem which is 15px this will be the font-size for both h1 and p, there is no need to give them a font-size after this.

To center .container on the page using flexbox, add justify-content: centerto the main and remove the margin value from .container.

Give the img a max-width of 100% instead of a width and add margin value for all the sides to .description. give h1 a margin-bottom value for the space between the text.

Use the colors that were given in the styleguide.md found in the zip folder you downloaded.

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

1

@BrijenMakwana

Posted

Really well done. Try to use em or px for width, padding. Don't use rem for that, use rem for fonts only.

Wish you luck.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord