At first there were difficulties with Tailwind and Framer Motion; it took a lot of time, but now it’s a little easier, because by overcoming difficulties we grow and become stronger. I wouldn't say that I'm not sure about anything. Can we do better? - Yes! Every day I am better than myself yesterday)
Marcos Travaglini
@BlackpachamameAll comments
- @wolterGraySubmitted 9 months ago@BlackpachamamePosted 9 months ago
Hey this looks really good, I could just suggest that you add a localStorage so that when you refresh the page the tasks you had added are kept.
The rest looks very good, the design and animations were fantastic 😎
Marked as helpful0 - @LuizFlavioPintoSubmitted 9 months ago@BlackpachamamePosted 9 months ago
Greetings! you have done a great job 😎
📌 Some suggestions
- I recommend doing a small
reset
to the styles that come by default in the browsers. To do this, you can apply a couple of properties to the universal selector*
, with this you will make your site look the same in all browsers - I leave you the task of researching the
reset CSS
and thebox-sizing: border-box
- Instead of using
position
to center your content in the center of the screen, you can use theflexbox
properties in thebody
:
body { background-color: black; min-height: 100vh; margin: 0; display: flex; justify-content: center; align-items: center; } main { background-color: #222222; /* position: absolute; delete */ /* top: 50%; delete */ /* left: 50%; delete */ /* transform: translate(-50%, -50%); delete */ width: 250px; height: 420px; text-align: center; border-radius: 10px; }
Marked as helpful0 - I recommend doing a small
- @maleyka13Submitted 9 months ago
blog preview card
@BlackpachamamePosted 9 months agoGreetings! you have done a great job 😎
- To improve the semantics of your HTML, you can change your
<div class="content">
to a<main class="content">
- Apply
max-width: 100%
to yourimg
so that it occupies the correct width within the container - Instead of using
margin
to center your content in the center of the screen, you can use theflexbox
properties in thebody
(Remove the margin from your content class):
body { background-color: hsl(47, 88%, 63%); min-height: 100vh; display: flex; justify-content: center; align-items: center; }
Marked as helpful0 - To improve the semantics of your HTML, you can change your
- @Eddieramirez29Submitted 9 months ago
It looks good at 375 px and around 1000px.
I would like to use SCSS and bootstrap5 on it to improve the view.
The calculations worked properly, so far.
Any suggestion is welcome.
¡Saludos!
@BlackpachamamePosted 9 months ago¡Saludos @Eddieramirez29!
Lo que pasa es que estás queriendo organizar los elementos con
position: absolute
lo cual lo hace un poco complicado. Lo que te recomiendo es que antes de usar SCSS o Bootstrap, aprendas a usar flexbox o grid y verás que será mucho mas sencillo que conposition: absolute
.También te recomiendo que investigues sobre el reset CSS, generalmente los navegadores traen estilos por defecto y con el reset podes manejarlo mucho mejor para que se vea en todos lados igual.
0 - @mbalali63Submitted 9 months agoWhat are you most proud of, and what would you do differently next time?
I have just done this project two times, but you will see the first try here. The first time I did it using tailwind-css and the second time with vanilla CSS. That was really interesting for me that I did it for the second time much faster and better. It reveals for me the practices and struggles in these days are working.
What challenges did you encounter, and how did you overcome them?Making it responsive was so challenging for me. But I resolve it using firefox Responsive Design Mode. I changed the screen size and check where the design was corrupted. then I add a @media for that size.
What specific areas of your project would you like help with?Al tough I think I resolved my problem with responsiveness, I am still sure that I am not working like professionals. I do like to know what techniques should I learn to do responsive design good.
@BlackpachamamePosted 9 months agoGreetings! you have done a great job 😎
📌 Some accessibility and semantics recommendations for your HTML
- To improve the semantics of your HTML, you can change your
<div class="container">
to a<main class="container">
and the<div class="attribution">
to a<footer class="attribution">
- Should be
h1
instead ofh2
- Instead of using
margin
to center your content in the center of the screen, you can use theflexbox
properties in thebody
:
body { margin: 0; line-height: inherit; min-height: 100vh; display: flex; justify-content: center; align-items: center; flex-direction: column; gap: 20px; /* Separate the main from the footer */ }
- The background color is not the same as the original design, nor the title of the card. You should check that, unless you changed it on your own
Marked as helpful0 - To improve the semantics of your HTML, you can change your
- @LEstebanRSubmitted 9 months ago@BlackpachamamePosted 9 months ago
¡Buen trabajo Luis! 😎
📌 Te dejo algunas sugerencias
- Podrías usar la etiqueta
<picture>
para cambiar de imagen dependiendo el tamaño de la pantalla. Más info - En pantallas mobile no se ve correctamente o por lo menos yo lo veo cortado. Esto es porque usaste
height: 100vh
en lugar demin-height
, lo que hace que se corte el contenido si hay un scroll vertical - Podrías agregarle el efecto hover al botón de
Add to cart
Marked as helpful1 - Podrías usar la etiqueta
- @waldohidalgoSubmitted 9 months ago@BlackpachamamePosted 9 months ago
¡Muy buen trabajo Waldo!
Te dejo algunas sugerencias:
- Puedes usar
width: 100%
en lugar dewidth: 100vw
, esto último suele generar un scroll horizontal - Puedes usar la etiqueta
details
junto consummary
para los elementos del acordeón. Más info
Marked as helpful1 - Puedes usar
- @paupalazzesiSubmitted 10 months ago@BlackpachamamePosted 10 months ago
¡Saludos Maria Paula! has hecho un buen trabajo 😃
📌 Te dejo algunas sugerencias
- Para mejorar la semántica de tu HTML, podes cambiar tu
<div class="card">
por<main class="card">
y<div class="attribution">
por<footer class="attribution">
- Podes usar
display: block
en tuimg
para quitar el espacio en blanco por debajo de la imagen. Aunque en este caso es visualmente irrelevante, pero puede ayudarte a calcular mejor los espacios entre un elemento y otro - El texto
Learning
no es unbutton
si no mas bien podría ser un enlacea
, ya que, al darle click te llevaría a otra página. Los botones se usan para funcionalidades como enviar un formulario o cambiar el tema del sitio - Los encabezados
h1
,h2
, etc, deben ir en orden del mayor al menor. En este caso tuh2
podría ser tranquilamente unp
- Como dijo el compañero en el otro comentario, no recomendaría usar
position: fixed
para estefooter
, si lo notas, en algunas pantallas llega a superponerse con la card y es algo molesto. En su lugar, podes seguir la recomendación que te dejaron de usarflex-direction: column
en elbody
, para que se vea correctamente tenes que quitar elposition: fixed
delfooter
y losmargin
en elcard
y dejar tubody
de la siguiente manera:
body { background: var(--yellow); display: flex; justify-content: center; align-items: center; flex-direction: column; gap: 2rem; /* Esto genera un espacio entre el main y el footer */ min-height: 100vh; margin: 0; /* Esto quita los márgenes que vienen por defecto en los navegadores en el body, podrías aplicarlo directamente como parte del reset en tu selector universal (*) */ }
Espero que estas sugerencias te ayuden a mejorar 🤓
0 - Para mejorar la semántica de tu HTML, podes cambiar tu
- @yanabueSubmitted 10 months ago@BlackpachamamePosted 10 months ago
Greetings! you have done a great job 😎
📌 Some suggestions
- You have linked the
favicon
in yourhead
, however, you did not upload it to your repository, therefore, it is not visible - To improve the semantics of your HTML, you can change your
<div class="container">
to a<main class="container">
- Do not use
%
forwidth
orheight
. Better userem
,em
orpx
- For some reason, error messages only appear below the year
input
- In the console you can see some
console.log
that you should delete - On mobile screens, the content protrudes from the main container
0 - You have linked the
- @Tranks-RXSubmitted 10 months ago@BlackpachamamePosted 10 months ago
Greetings! you have done a great job 😎
📌 Some accessibility and semantics recommendations for your HTML
- To improve the semantics of your HTML, you can change your
<div class="container">
to a<main class="container">
- The
attribution
should go outside themain
📌 Some suggestions
- I recommend doing a small
reset
to the styles that come by default in the browsers. To do this, you can apply a couple of properties to the universal selector*
, with this you will make your site look the same in all browsers - I leave you the task of researching the
reset CSS
and thebox-sizing: border-box
- If you didn't apply the reset, you can add
margin: 0
to yourbody
, this will remove annoying scrolling on large screens. If you want to maintain separation on very small screens, you can apply themargin
again using media querys - You can use the
gap
property in thebody
to separate yourmain
from yourfooter
- Instead of using
margin
to center your content in the center of the screen, you can use theflexbox
properties in thebody
:
body { background-color: hsl(217, 54%, 11%); /* padding: 100px; */ font-family: 'Outfit'; margin: 0; /* reset */ min-height: 100vh; display: flex; justify-content: center; align-items: center; flex-direction: column; gap: 20px; /* Separate the main from the footer */ }
Marked as helpful1 - To improve the semantics of your HTML, you can change your
- @KhDyanneSubmitted 10 months ago
Is the centering and responsiveness well done?
@BlackpachamamePosted 10 months ago📌 Some accessibility and semantics recommendations for your HTML
- To improve the semantics of your HTML, you can change your
<div class="container">
to a<main class="container">
and the<div class="attribution">
to a<footer class="attribution">
- The
attribution
should go outside themain
📌 Some suggestions
- Add a
padding
to generate interior space on your card. This prevents you from usingmargin
orpadding
on child elements to achieve the same result - Use
min-height
andmax-width
, this will help the content stretch or shrink if you need to. Unlikeheight
andwidth
which can cause your content to be cut off on certain screens. For example, usemin-height: 100vh
instead ofheight: 100vh
- Apply
max-width: 100%
to yourimg
so that it occupies the correct width within the container - I think that the
img
of the banner does not occupy the corresponding width because you applied aheight: 370px
, at least on desktop screens, this causes the borders to not be seen correctly. To solve it, you could leave theheight: auto
, addmax-width: 100%
- Instead of using
margin
to center your content in the center of the screen, you can use theflexbox
properties in thebody
:
body { background-color: rgb(223, 223, 237); /* margin: 15% auto 15% auto; */ font-family: 'Segoe UI', Tahoma, Geneva, Verdana, sans-serif; min-height: 100vh; display: flex; justify-content: center; align-items: center; flex-direction: column; gap: 20px; /* Separate the main from the footer */ }
- Correct and add the following to your
card
class:
.card { min-height: 400px; max-width: 320px; padding: 16px; text-align: center; background-color: white; box-shadow: 2px 2px 2px 1px rgb(0 0 0 / 20%); } h4 { /* padding: 0 10px 0 10px; */ margin-block: 15px; color: rgb(18, 18, 77); font-weight: bold; font-size: 23px; }
Marked as helpful1 - To improve the semantics of your HTML, you can change your
- @catarinayumSubmitted 10 months ago@BlackpachamamePosted 10 months ago
Greetings! you have done a great job 😎
📌 Some accessibility and semantics recommendations for your HTML
- To improve the semantics of your HTML, you can change your
<div class="container">
to a<main class="container">
and the<div class="attribution">
to a<footer class="attribution">
- Use
min-height
andmax-width
, this will help the content stretch or shrink if you need to. Unlikeheight
andwidth
which can cause your content to be cut off on certain screens. For example, usemin-height: 100vh
instead ofheight: 100vh
- I recommend doing a small
reset
to the styles that come by default in the browsers. To do this, you can apply a couple of properties to the universal selector*
, with this you will make your site look the same in all browsers - I leave you the task of researching the
reset CSS
and thebox-sizing: border-box
- You can apply
display: block
to the image to remove the white space generated underneath. Although visually in this case it is irrelevant, it helps you better calculate the space with other elements
0 - To improve the semantics of your HTML, you can change your