About Responsive age calculator, calculating years, months, days.

Community feedback

• 

  Marcos Travaglini•4,840

  @BlackpachamamePosted 10 months ago

  Greetings! you have done a great job 😎

  📌 Some suggestions

  • You have linked the favicon in your head, however, you did not upload it to your repository, therefore, it is not visible
  • To improve the semantics of your HTML, you can change your <div class="container"> to a <main class="container">
  • Do not use % for width or height. Better use rem, em or px
  • For some reason, error messages only appear below the year input
  • In the console you can see some console.log that you should delete
  • On mobile screens, the content protrudes from the main container

  0

  ---

  

  Yana•390

  @yanabuePosted 10 months ago

  @Blackpachamame Thanks for the in-depth review and comments! Fixed what you said, seems to be much better now.

  I've got a couple questions if you don't mind, would help me improve:

  • Why is it reccomended to not use % for width/height? also does that apply to max/min-width?
  • It might be a too specific question, but I've checked the app in my iPhone safari browser, and for some reason, for any date input I use, it returns an error. Checked it on an android, it was fine. Why could that be? Could it be because of how the IOS provides the Date object to the app?

  0

  

  Marcos Travaglini•4,840

  @BlackpachamamePosted 10 months ago

  @yanabue

  • Because % doesn't fit as well as other units like rem, em or px
  • I now see the errors display correctly

  0