@its-subhash
Posted
Hey @paupalazzesi , your solution looks pretty good but I just came across two major problems i would like to address, and I have some advice to how to correct those with least amount of efforts.
1.Fixed Footer :
Footer or say attribution is fixed at one place so while scrolling of even normally it comes above card, this problem can be fixed by completely removing .attribution{}
class and adding flex-direction:column
and gap:2rem
inside body selector.
2.Scroll Bar:
It's not that of a big deal and can be ignored but in my opinion there should not be need of a scroll bar for just a card. And the best solution for it is quite headache to do when you came this far, so the easiest way I can do it is you can put margin-top:16vh
insted of margin:20vh
in .card
class, this will add margin to the top only and it'll be centered.
Additionally I saw lots of margins and paddings on elements which isn't that good thing, so you can explore it's better alternative, like explore flex and grid little more.
Rest of the code was really good, I hope you'll find this helpful.
Marked as helpful