Skip to content
OverviewSolutions
4
Comments
2
Bakek-lang
@Bakek-lang

All comments

  • Sithembiso Ngwenya•10
    @ngwwSubmitted over 1 year ago

    Feedback welcome, especially feedback on how to make the css and html flow together better and possibly use less of it

    QR Code Web Page

    1
    Bakek-lang•80
    @Bakek-langPosted over 1 year ago

    Congratulations on finishing this project!

    I have a few suggestions on how you can make your solution include semantic HMTL and improve between the CSS and HTML.

    • Use <main>instead of <div> on the cardboard and <footer>instead of <div> on the footer.
    • To have more control over the CSS i would recommend using a stylesheet just for CSS, instead of applying the CSS inside of index.html
    • Use flex or grid to place the main section to the middle of the page
    • You can also place your name/alias at the bottom of the page where it says "Your Name Here"

    Well done with your solution, hope this helps.

    Marked as helpful
    1
  • Bakek-lang•80
    @Bakek-langPosted over 1 year ago

    Congratulations on finishing this project.

    There are a few changes you can do to improve your solution to include semantic HTML.

    • Use <main> instead of <div>

    • There is no reason to use multiple h2´s and mutiple <p> with <br>if you use the correct fontsizes, font-weights and lineheights.

    • Use CSS for design solutions, not html.

    For the CSS:

    • Keep it DRY (Dont repeat yourself), you can read more about it here:

    • Use grid or flex to center the card both vertically and horizontally

    Hope this helps and keep working!

    0