QR code component

Community feedback

• 

  Bakek-lang•80

  @Bakek-langPosted over 1 year ago

  Congratulations on finishing this project.

  There are a few changes you can do to improve your solution to include semantic HTML.

  • Use <main> instead of <div>

  • There is no reason to use multiple h2´s and mutiple <p> with <br>if you use the correct fontsizes, font-weights and lineheights.

  • Use CSS for design solutions, not html.

  For the CSS:

  • Keep it DRY (Dont repeat yourself), you can read more about it here:

  • Use grid or flex to center the card both vertically and horizontally

  Hope this helps and keep working!

  0