Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

Biruk 40

@BirukNigusie

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@Bakek-lang

Posted

Congratulations on finishing this project.

There are a few changes you can do to improve your solution to include semantic HTML.

  • Use <main> instead of <div>

  • There is no reason to use multiple h2´s and mutiple <p> with <br>if you use the correct fontsizes, font-weights and lineheights.

  • Use CSS for design solutions, not html.

For the CSS:

  • Keep it DRY (Dont repeat yourself), you can read more about it here:

  • Use grid or flex to center the card both vertically and horizontally

Hope this helps and keep working!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord