Skip to content
OverviewSolutions
5
Comments
3
Avitohol_
@Avitohol1

All comments

  • Avitohol_•190
    @Avitohol1Posted over 1 year ago

    Nice job! When you click one of the border countries or reload the page, the dark theme is reset to light. Maybe use local storage to persist the theme whenever the page reloads?

    0
  • Avitohol_•190
    @Avitohol1Posted over 1 year ago

    Hi and congrats for completing the challenge! Here are some things I hope will be helpful for you:

    1. In the HTML I recommend you use a <button type="submit"> > </button> in place of the submit input you currently have. The button is more explicit.
    2. There is no responsiveness to your design - you can use media queries for that.
    3. On line 11 there is a typo for the second argument of fetch. But you can actually remove the argument completely as the default method for fetch is "GET" - like this: const response = await fetch(url)
    4. In the app.js when you call the updateMap() function you are creating a new map on every call. So every time when you click the submit button a new map is added on top of the old one and this is ineffective and also you can't drag the new map. A way to fix this would be to initialize the map once in the beginning of your code and then use the map.panTo() method
    Marked as helpful
    0
  • YuvCarl•180
    @CarlTeclancingSubmitted about 2 years ago

    i need help on how to host react apps on github pages someone help me please😢

    Clipboard landing page

    2
    Avitohol_•190
    @Avitohol1Posted about 2 years ago

    Hi there - I saw from your package.json that you have installed gh-pages. Did you run npm run deploy and if so are there any errors that show up? Anyways this is my process on publishing to gh-pages:

    1. Install gh-pages (npm install gh-pages --save-dev)
    2. Create github repository
    3. git add .
    4. git commit -m 'first commit'
    5. git branch -M main
    6. git remote add origin https://github.com/{your_username}/{your_repo}.git
    7. git push -u origin master
    8. npm run deploy

    Also, make sure you have the correct homepage in package.json Hope this helps!

    Marked as helpful
    0