IP Address Tracker

Community feedback

• 

  Avitohol_•190

  @Avitohol1Posted over 1 year ago

  Hi and congrats for completing the challenge! Here are some things I hope will be helpful for you:

  1. In the HTML I recommend you use a <button type="submit"> > </button> in place of the submit input you currently have. The button is more explicit.
  2. There is no responsiveness to your design - you can use media queries for that.
  3. On line 11 there is a typo for the second argument of fetch. But you can actually remove the argument completely as the default method for fetch is "GET" - like this: const response = await fetch(url)
  4. In the app.js when you call the updateMap() function you are creating a new map on every call. So every time when you click the submit button a new map is added on top of the old one and this is ineffective and also you can't drag the new map. A way to fix this would be to initialize the map once in the beginning of your code and then use the map.panTo() method

  Marked as helpful

  0