@marwinfbSubmitted 5 months ago
Asv000
@Asv000All comments
- @Asv000Posted 5 months ago
Hey! Your solution looks good! I'd suggest using bigger font sizes so it matches the design. Also your footer has some white space which is unnecessary. Otherwise good job mate, you nailed it! Also I think your code looks good but I can give you a little tip: In your next solutions try to use this CSS order: group1[position, top/left/bottom/right display] group2[margin, padding, width, height], group3 [color, background-color, border] group4 [font-size, line-height]. group5[transition, cursor, z-index] so your code can be easy to read and change
Marked as helpful0 - @WB52Submitted 7 months agoWhat are you most proud of, and what would you do differently next time?
Mobile first design...
Next time I would probably experiment and try grid areas.
Maybe I’d include more breakpoints in the media queries as it goes straight from mobile to desktop and back. I never thought much about changing the design for tablet size, although the mobile will show and work ok.
What challenges did you encounter, and how did you overcome them?I enjoyed getting to grips with grid and found it tricky on the as desktop layout at times but enjoyed the learning process.
What specific areas of your project would you like help with?Any feedback and suggested improvements always welcome, thanks...
@Asv000Posted 6 months agoHello there! You design is almost pin-point! You did a veeeeeeery good job there, keep it up! By looking at your HTML code I think you are using too much sections (I'm a newbie but that seems a little bit too many for me). Layout looks great on mobile devices (maybe a little bit of padding for 320px) but overall RWD did great! Your code looks clean and is defiently reusable. I wonder you spent a lot of time calculating those rems tho :P That's a great work! Really great! Keep pushing mate 8)
Marked as helpful0 - @anniekrdlSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I did it real quick.
What challenges did you encounter, and how did you overcome them?I didn't get the grid-area right. I googled it.
What specific areas of your project would you like help with?None
@Asv000Posted 6 months agoEven if you don't need help with any area of the project I need to say that this is a good job done! If I could point something out is only that you should check those widths on cards and breakpoint after 375px because it looks sketchy. Overall project is nice, it's good, glad you made it fast and you are proud of that, keep it up 8)
0 - @MohakGogiaSubmitted 10 months agoWhat are you most proud of, and what would you do differently next time?
Will try to make it more responsive
What challenges did you encounter, and how did you overcome them?Applying styling according to different breakpoints as in which changes to be done
What specific areas of your project would you like help with?Playing more with relative units to scale automatically with the screen size
@Asv000Posted 6 months agoHey that looks nearly perfect! You need to check those line heights for text and button size, otherwise I believe that's a good job! Keep going :)
0 - @VishumateSubmitted 6 months ago@Asv000Posted 6 months ago
From my POV HTML semantic looks fine. Your solution differ from design quite significantly so when you comeback to this, please try to fix it. Layout on other devices looks good althought image on 320px and 375 doesn't look quite right. I believe that code is well structured and readable.
Marked as helpful0 - @6633256621Submitted 6 months ago@Asv000Posted 6 months ago
It looks like you need to change the font weight for name and location. Also you should make a little bit more space for buttons. I don't think that you should use strong tag for buttons. If you want to use it only for decoration, b tag is fine, but if you want to add semantic for it then strong is the case there. You alt text should be more descriptive like: picture of Jessica or something like that instead of just "jessica". You should also check media queries for mobiles smaller than 375px. I think rest looks fine, keep it up :)
0 - @hmousavinSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
I'm happy to continue doing the challenges
What challenges did you encounter, and how did you overcome them?the "margin: 10vh auto" didn't work for me to cauterize the elements horizontally, since i used "max-width: 21vw" both in "body" and "main" .. so after using non-responsive units, every thing works (e.g with max-width: 320px)
What specific areas of your project would you like help with?when should we use responsive and we shouldn't use? besides that, there's a lot of facilities to achieve responsiveness in css, and honestly I'm not sure where and when I need to use them!
@Asv000Posted 6 months agoFrom my point of view besides of it's height on preview project looks pretty fine. I think semantic HTML is fine but I don't like that you used button for Learning. I don't really thing that's neccessary and you could achieve that in other way eg. using P with display: inline-block and padding. You definetly need to practice with RWD but don't worry MDN got good guide for why and when. I'm also learning a new things brother, we all gonna make it :) I see that your CSS file looks kinda weird, but pretty similar to SCSS Check this SASS introduction, maybe you'll like it! Remember to never give up and keep trying!
Marked as helpful0 - @Kamesh-TSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
solution is mobile first and responsive. next time I will try to optimize my solution in efficient way
What challenges did you encounter, and how did you overcome them?align the texts in proper position. By wrap these texts in a div container I overcome the problem.
What specific areas of your project would you like help with?aligning the flex items in visually appealing way.
@Asv000Posted 6 months agoNext time instead of wrapping text in div you could use on body: display: flex; justify-content: center; align-items: center; flex-direction: column; So there won't be a problem if you wrapped your texts with .cards
You should also check color pallete once again and change color for paragraph and h3.
Marked as helpful0
