Design comparison
Solution retrospective
I'm happy to continue doing the challenges
What challenges did you encounter, and how did you overcome them?the "margin: 10vh auto" didn't work for me to cauterize the elements horizontally, since i used "max-width: 21vw" both in "body" and "main" .. so after using non-responsive units, every thing works (e.g with max-width: 320px)
What specific areas of your project would you like help with?when should we use responsive and we shouldn't use? besides that, there's a lot of facilities to achieve responsiveness in css, and honestly I'm not sure where and when I need to use them!
Community feedback
- @Asv000Posted 6 months ago
From my point of view besides of it's height on preview project looks pretty fine. I think semantic HTML is fine but I don't like that you used button for Learning. I don't really thing that's neccessary and you could achieve that in other way eg. using P with display: inline-block and padding. You definetly need to practice with RWD but don't worry MDN got good guide for why and when. I'm also learning a new things brother, we all gonna make it :) I see that your CSS file looks kinda weird, but pretty similar to SCSS Check this SASS introduction, maybe you'll like it! Remember to never give up and keep trying!
Marked as helpful0 - @danielmrz-devPosted 6 months ago
Hello there!
Congrats on completing the challenge! ā
Your project is looking fantastic!
I'd like to suggest a way to make it even better:
- Using
margin
isn't always the most effective method for centering an element.
Here's a highly efficient approach to position an element at the center of the page both vertically and horizontally:
š Apply this CSS to the body (avoid using
position
ormargins
in order to work correctly):body { min-height: 100vh; display: flex; justify-content: center; align-items: center; }
I hope you find this helpful!
Keep up the excellent work!
1 - Using
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord