@marcfrancissSubmitted 9 months ago
Latest solutions
Contact form using SCSS
#sass/scssSubmitted 7 months agoI need feedback on how accessible is my site and how readable is my project.
FAQ Accordion using SCSS
#sass/scssSubmitted 7 months agoFeedback on the accessibility standards I applied here. Thank you!
Interactive Rating Component using SCSS
#sass/scssSubmitted 7 months agoI need checks regarding uses of ARIA attributes. I don't know exactly where and how to use all of them, so feel free to give me feedback on that
Tip Calculator using SCSS
#sass/scssSubmitted 7 months agoNone really. I would like to hear other optimized solutions
Time-tracking Dashboard using SASS
#sass/scssSubmitted 7 months agoI would love if I would be pointed better solutions for the json data manipulation, so that, if there would be added another timeframe as a tab, the whole process of adding is done easier.
Newsteller Sign Up using SCSS
#sass/scssSubmitted 8 months agoNot quite sure what I could have done better regarding the responsiveness of the website.
Latest comments
- @mohammadfallah7Submitted 9 months ago@Alexandru736Posted 7 months ago
Hi @mohammadfallah7
I have two remarks on your solution:
- First, regarding your background-image, for larger screens, it doesn't fully stretches the screen width. For the
<body>tag, you could set the 'background-image: url('your-image')' and thebackground-size: contain. It might not stretches the ideal way, but at least it does the trick. - Secondly, you have overloaded your js script. Ideally, make your HTML with all attributes and elements you need. For example, you could have added both buttons for each question and set the default one with
display: blockand the other one withdisplay: none. Then, instead of creating anactivetype of class, you could have used ARIA attributes likearia-hidden="true"and when you click the button, the attribute of the default button would have the value true and the other one false, and so on. Overall, great project and good job on using SCSS. Keep up the good work!
Best, Alex
0 - First, regarding your background-image, for larger screens, it doesn't fully stretches the screen width. For the
- @dolapobjSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
I thought the organization of my JS code was very good, and easy to follow. Doing easy projects like this helps me reinforce the different logical aspects of working with JS. variables, functions, event listeners, etc.
What specific areas of your project would you like help with?Any feedback on my JS would be great!
@Alexandru736Posted 7 months agoHi @dolapobj!
Nice project! The logic in the JS file looks great. Regarding the styling updates you need to make when you click the buttons, I believe that you should make use of ARIA attributes. For example, the way your tip buttons work is the same as radio buttons. Therefore, you could use
aria-checked. Another thing, this time regarding the HTML tree, avoid usingdivs and spansas much as possible. This recommendation comes from using HTML semantics more. They make web accessibility a lot easier.Keep up the good work!
Best, Alex
0 - P@wideirpSubmitted 7 months ago
- P@juliusalbertoSubmitted 8 months ago@Alexandru736Posted 7 months ago
Hi! I really appreciate your work. The design looks really cool, as well as your code. It is well structured and easy to read. This is not something to change but a suggestion you could take into consideration for your future projects. When it comes to web accessibility, I highly recommend using the ARIA standards. You could look it up yourself, by accessing the website https://www.w3.org/WAI/ARIA/apg/patterns/ Good luck!
0 - @bartoszdudziak-devSubmitted 11 months agoWhat are you most proud of, and what would you do differently next time?
I would add some transition on hover effect. Due to usage input tags I couldn't create pseudo elements on them which could let me to change background with effect. Perhaps I would let my wrapper grow a little bit before it achieves the breakpoint.
What challenges did you encounter, and how did you overcome them?I didn't have much serious problems.
What specific areas of your project would you like help with?Accessibility
