Interactive Rating Component using SCSS

Community feedback

• 

  P

  Teodor Jenkler•3,740

  @TedJenklerPosted 2 months ago

  Hi @Alexandru736,

  Nice project! I would urge you to consider solving this challenge using JavaScript and buttons instead(As a form). It’s valuable to know how to implement this in JavaScript because it will make your buttons and "radio boxes" accessible "automatically." For instance, you can use role="button" and role="radio" attributes to inform the screen reader about the purpose of these elements if making custom radio buttons.

  Keep up the good work!

  Best, Teodor

  Marked as helpful

  0

  ---

  

  Alexandru736•210

  @Alexandru736Posted 2 months ago

  Hi @TedJenkler

  Thank you for your response! I reviewed what you said and made some improvements. If it's ok for you, I would like another review, to check if I did right.

  Thank you very much!

  Best regards, Alex

  1

  

  P

  Teodor Jenkler•3,740

  @TedJenklerPosted 2 months ago

  @Alexandru736 Yes will look at it when I get home, bookmarked it

  0

  

  P

  Teodor Jenkler•3,740

  @TedJenklerPosted 2 months ago

  @Alexandru736, you scored 100% on accessibility and 99% on optimization. (Lighthouse mentioned that some images could be optimized, but there’s no immediate need to change them.) Your lowest score was 90% on SEO, but your site is still really good. You could consider changing the <h1> to <h2> because it might not be the main page title, but as long as you don’t use <h1> for more than one page in bigger projects, it should be fine.

  One thing I noticed is that the buttons are using a grid layout, which isn't against any rules that I know of, but it seems like a complex way to center the numbers. I assume this is why you chose this approach.

  Anyways, great job on this project!

  Marked as helpful

  0