Design comparison
Solution retrospective
I feel proud that I worked smoother with JS
What challenges did you encounter, and how did you overcome them?I encountered no challenges this time
What specific areas of your project would you like help with?I need checks regarding uses of ARIA attributes. I don't know exactly where and how to use all of them, so feel free to give me feedback on that
Community feedback
- @TedJenklerPosted 3 months ago
Hi @Alexandru736,
Nice project! I would urge you to consider solving this challenge using JavaScript and buttons instead(As a form). It’s valuable to know how to implement this in JavaScript because it will make your buttons and "radio boxes" accessible "automatically." For instance, you can use role="button" and role="radio" attributes to inform the screen reader about the purpose of these elements if making custom radio buttons.
Keep up the good work!
Best, Teodor
Marked as helpful0@Alexandru736Posted 3 months agoHi @TedJenkler
Thank you for your response! I reviewed what you said and made some improvements. If it's ok for you, I would like another review, to check if I did right.
Thank you very much!
Best regards, Alex
1@TedJenklerPosted 3 months ago@Alexandru736 Yes will look at it when I get home, bookmarked it
0@TedJenklerPosted 3 months ago@Alexandru736, you scored 100% on accessibility and 99% on optimization. (Lighthouse mentioned that some images could be optimized, but there’s no immediate need to change them.) Your lowest score was 90% on SEO, but your site is still really good. You could consider changing the <h1> to <h2> because it might not be the main page title, but as long as you don’t use <h1> for more than one page in bigger projects, it should be fine.
One thing I noticed is that the buttons are using a grid layout, which isn't against any rules that I know of, but it seems like a complex way to center the numbers. I assume this is why you chose this approach.
Anyways, great job on this project!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord