Adrian• 240
@JustCode11
Submitted
I finished this project to exercise my Angular skills.
I had a lot of fun with this challenge.
I'm quite a newbie in Angular, so let me know if you have any suggestions of improvement or Best Practice that I missed.
Alberto Muñoz
@AlbertooMunozz
All comments
- Alberto Muñoz• 120
@AlbertooMunozz
Posted
Hi, @JustCode11, I congratulate you on your work and your contribution to this challenge."
It is an incredible and well-controlled work, but here is my suggestion for you:
- Input Name : Please make sure the input only allows a limited number of characters and only permits the typing of letters.
- Input Email : Ensure that the entered email is correct and uses all the necessary characters for this parameter.
- Input Phone: Make sure the input only allows numbers and has a minimum of 8 and a maximum of 15 characters (these amounts are undefined)
I hope you can continue sharing your solutions and keep improving 😁
Marked as helpful
1 - Fred Campo• 330
@fredcamp
Submitted
How important and powerful RegEx can do when it comes to client side validations. And how amazing ES7 String Padding when displaying output and placeholders.
Alberto Muñoz• 120@AlbertooMunozz
Posted
Hi, Fred Campo 😄
Congratulations on your contribution to this platform and for being able to share your solution to this challenge. Your solution was incredible, and the implementation of your animations and responsiveness are excellent.
Here are a few things I noticed:
-
input number : You should use
padEnd(16, value) instead ofpadStart()`. This way, the generated numbers will appear at the end and not at the beginning, so the animation of your card on the screen will be from left to right. Control the input to only 16 characters to prevent the card from breaking -
input expiration mm: Control that the input consists of numbers between 1 and 12 to ensure it is a valid date.
Marked as helpful
1 -
- Juan Diego• 20
@NeeFar
Submitted
This is my project!
Alberto Muñoz• 120@AlbertooMunozz
Posted
Hola, Diego, te felicito por tu aporte a este reto 😃. El responsive de tu codigo es maginfico, ademas, es bastante acercado al diseño original, mi unica recomendacion en trabajar la vista en celulares estrechos, como el galaxy fold (280px x 653px). Espero puedas seguir subiendo mas aportes y sigas mejorando😎.
Marked as helpful
1 - Debjit Datta• 160
@deb1401jit
Submitted
Alberto Muñoz• 120@AlbertooMunozz
Posted
Hi, Debjit Datta, I congratulate you for your contribution to this challenge😎. The responsive is incredible but the card number input has an error and it marks that it is wrong despite having all the numbers 🤔. The expiration input are not controlled. You could use 'date' to control that they are correct dates
1
