Skip to content
OverviewSolutions
14
Comments
8

Alan Lopez Reyna

@AlanLopReyMexico300 points

I'm from México / Self-taught front-end web developer / 25 years old

I’m currently learning...

JavaScript

Latest solutions

View more solutions

Latest comments

  • Joseph K. L Lartey•430
    @FlackoCodes
    What are you most proud of, and what would you do differently next time?

    Getting my hands dirty with useSate hook in React for updating the errors.

    What specific areas of your project would you like help with?

    Got stuck with updating the form inputs color to red when the are erros.

    Responsive age calculator app

    #accessibility#react#pure-css
    2
    Alan Lopez Reyna•300
    @AlanLopRey

    You have several problems, like:

    • you allow users to put negative numbers
    • you need to separate the code into smaller and more handle functions, you can do this by using custom hooks

    I will make you a PR to solve those problems. Have a good day

  • P
    good-mistake•1,040
    @good-mistake
    What specific areas of your project would you like help with?

    Any feedback is welcome.

    Calculator

    1
    Alan Lopez Reyna•300
    @AlanLopRey

    the multiplication operation doesn't work

    Marked as helpful
  • Alan Lopez Reyna•300
    @AlanLopRey

    EXCELLENT WORK BRO I can give you a few tips

    1. Star to use semantic tags in the HTML to improve accessibility
    2. Use the semantic tags in the HTML gives you a better way to name the classes with BEM only using the name of the tag, for example if you have a main element you can name it with the same name in the css, for small projects like this work very well

    beside that you do a excellent work

    Marked as helpful
  • Alan Lopez Reyna•300
    @AlanLopRey

    Hola bro saludos desde México 🇲🇽 hiciste un excelente trabajo a mi parecer, pero hay un par de cuestiones en tu codigo que podrias mejorar, en cuanto al documento HTML tienes un h3 antes que un h2 entonces primero tendrias que tener un h2 en tu codigo tienes

           <h3>12m+</h3> <span class="span2">queries</span>
    </div>

    cuando deberia ser mejor

           <h2>12m+</h2> <span class="span2">queries</span>
    </div>

    tambien en el formateo de tu codigo no es necesario poner porcentaje o px simplemente dejandolo en 0 basta

    tu codigo 👇

    *{
    margin: 0%;
    padding: 0%;
    
}

    como seria mas adecuado a buenas practicas 👇

    *{
    margin: 0;
    padding: 0;
    box-sizing: border-box;
}

    Te recomiendo este canal de youtube para que le des una repasada a todo lo de CSS, HTML y Js, es un increible maestro y lo mejor de todo es gratuito, animo hermano vas excelente

    Espero te sirva 😀

    Marked as helpful
  • Alan Lopez Reyna•300
    @AlanLopRey

    Hola buenas noches Nathan, excelente trabajo pero seria buena idea que empieces a utilizar otros metodos de layout como Flexbox y Grid no solamente te haran el trabajo mas facil si no que no tendras tantos errores a la hora de hacer el diseño responsive, por otra parte tambien te recomendaria que empezaras todos tus layouts con la metodologia Mobile first, justamente acabo de terminar este mismo proyecto puedes ir a verlo, usa las teclas ctrl + shift + m para poder ver los layout en diferentes medidas. Tambien te recomiendo que hagas el README por seguir las buenas practicas

    Marked as helpful
  • Alan Lopez Reyna•300
    @AlanLopRey

    Hi good attempt, that happen because you need to do a reset of the padding and margin and you forget do it, in this part of you code *, *::before, *::after { box-sizing: border-box; font-family: Outfit, Ubuntu, sans-serif; } you only need to put the margin and padding at zero like this *, *::before, *::after { box-sizing: border-box; font-family: Outfit, Ubuntu, sans-serif; margin: 0; padding: 0; } I hope that help you

View more comments