All comments

• 

  Travis• 20

  @travis-the-coder

  Submitted 11 months ago

  It has been a while since I was practicing how to code. I would like some feedback as I am trying to get back into it in hopes to have a career change.

  Questions:

  • Is there anything that could have been done to make the code more efficient?
  • Are there any places in the code that you would advise I do differently?
  • Is there any spot in the project that I could improve on?

  

  Beginner's Challenge: QR Code [HTML & CSS] using VS Code

  1

  50

  

  Aviral• 160

  @Akunamo

  Posted 11 months ago

  Hi Travis, i am no expert so take me advice with a bit of salt.

  You should not use margin like that on the body to center things (i have been through this phase of "how to center").

  A simple ways is using grid and place-items(on body in this case) i suggest you do some research on grid and flex. You can also use main html sementic element instead of a div(.layer-1) for the card, main simply means that this is the main content of the page (though it is also helpful for accessibility and landmark, but you will get to know these thing later in your journey).

  have fun.

  0

  This comment has received 2 repliesShow
• 

  Aviral• 160

  @Akunamo

  Submitted over 1 year ago

  It was a pain to name things in this project. I consider myself decent with js, but this project was all about how to manage your code and html structure. but I thing i know what i need to do (practice a lot more Intermediate project for more experience)

  Btw I appreciate all the feedback

  

  Responsive using grid

  2

  30

  

  Aviral• 160

  @Akunamo

  Posted over 1 year ago

  I suck at creating forms btw

  0
• 

  Alexander• 120

  @zerescas

  Submitted almost 2 years ago

  

  Order summary component with Flexbox and Grid

  2

  30

  

  Aviral• 160

  @Akunamo

  Posted almost 2 years ago

  Hey Aleksandr I saw your code and its pretty neat and really clean.

  But at the footer section you used two div, one with class of top-left-decoration and bottom-right-decoration, instead of that you can use pseudo elements :before and :after, these elements are mostly used for decorative purpose and it helps write less html.

  Happy Coding!

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  Parthib45• 220

  @Parthib45

  Submitted over 2 years ago

  Tried my best as a newbie. hopping to get some constructive feedback.

  

  Responsive order summary

  2

  61

  

  Aviral• 160

  @Akunamo

  Posted over 2 years ago

  Well done

  i am a newbie as well but i think It is realy great everything is in place , the preview might look different because of different screen sizes i suggest you use inspect mode or learn more about it. The background image is repeating to fill the screen to stop that you can use background-repeat: no-repeat; you can learn more about background properties on youtube so you can have more control over the backgroud

  0