Skip to content
Submitted about 1 year ago

Beginner's Challenge: QR Code [HTML & CSS] using VS Code

Travis•20
@travis-the-coder
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

It has been a while since I was practicing how to code. I would like some feedback as I am trying to get back into it in hopes to have a career change.

Questions:

  • Is there anything that could have been done to make the code more efficient?
  • Are there any places in the code that you would advise I do differently?
  • Is there any spot in the project that I could improve on?

Community feedback

  • Aviral•160
    @AkunamoPosted about 1 year ago

    Hi Travis, i am no expert so take me advice with a bit of salt.

    You should not use margin like that on the body to center things (i have been through this phase of "how to center").

    A simple ways is using grid and place-items(on body in this case) i suggest you do some research on grid and flex. You can also use main html sementic element instead of a div(.layer-1) for the card, main simply means that this is the main content of the page (though it is also helpful for accessibility and landmark, but you will get to know these thing later in your journey).

    have fun.

    0
    Travis•20
    @travis-the-coderPosted about 1 year ago

    @Akunamo Thank you for the feedback. I will look into this and see how I can improve it as it has been a while.

    0
    Travis•20
    @travis-the-coderPosted about 1 year ago

    @Akunamo Thank you for the feedback. I will look into this and see how I can improve it as it has been a while.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord