MYNMā¢ 120
@YoonadiMon
Submitted
AhmarIftikhar123
@AhmarIftikhar123
All comments
- AhmarIftikhar123ā¢ 660
@AhmarIftikhar123
Posted
Assalam-o-alaikum! Dear YoonadiMon,
I hope this message finds you well. I appreciate your efforts in working on the recent project code. I've identified a few areas where improvements can be made for better maintainability, design consistency, and responsiveness.
Layout Design and Responsiveness:
The current layout design appears to have a high degree of complexity, leading to potential difficulties in maintenance and scalability.Text starts overflowing on the 700px width.
Pixel Perfect Design:
The site is not achieving pixel-perfect results, particularly on specific pixel widths. Consistency in design across different resolutions is crucial for a polished and professional appearance. Grid Usage:
The absence of a grid system can contribute to the challenges in maintaining a consistent layout. Introducing a grid system will greatly enhance the overall structure and organization of the code. Watch Youtube video:
https://www.youtube.com/watch?v=rg7Fvvl3taU&ab_channel=KevinPowellRecommendation:I strongly recommend incorporating a grid system into the layout. Utilizing a grid will not only simplify the code but also enhance the site's responsiveness and ensure a more consistent and visually appealing design.
Continuous Learning:
I understand that learning new concepts might be challenging, but the benefits will undoubtedly reflect in the quality of your work. If you have any questions or need guidance on implementing grid systems, feel free to reach out. I'm here to support your professional development.
Thank you for your dedication to this project, and I look forward to seeing the improvements in the next iteration.
Best regards, [Ahmar Iftikhar]
Marked as helpful
0 - MYNMā¢ 120
@YoonadiMon
Submitted
AhmarIftikhar123ā¢ 660@AhmarIftikhar123
Posted
Assalam-o-alaikum! Dear YoonadiMon,
I hope this message finds you well. I appreciate your efforts in working on the recent project code. I've identified a few areas where improvements can be made for better maintainability, design consistency, and responsiveness.
Layout Design and Responsiveness:
The current layout design appears to have a high degree of complexity, leading to potential difficulties in maintenance and scalability.Text starts overflowing on the 700px width.
Pixel Perfect Design:
The site is not achieving pixel-perfect results, particularly on specific pixel widths. Consistency in design across different resolutions is crucial for a polished and professional appearance. Grid Usage:
The absence of a grid system can contribute to the challenges in maintaining a consistent layout. Introducing a grid system will greatly enhance the overall structure and organization of the code. Watch Youtube video:
https://www.youtube.com/watch?v=rg7Fvvl3taU&ab_channel=KevinPowellRecommendation:I strongly recommend incorporating a grid system into the layout. Utilizing a grid will not only simplify the code but also enhance the site's responsiveness and ensure a more consistent and visually appealing design.
Continuous Learning:
I understand that learning new concepts might be challenging, but the benefits will undoubtedly reflect in the quality of your work. If you have any questions or need guidance on implementing grid systems, feel free to reach out. I'm here to support your professional development.
Thank you for your dedication to this project, and I look forward to seeing the improvements in the next iteration.
Best regards, [Ahmar Iftikhar]
0 - Eman Radwanā¢ 200
@EmanRadwan114
Submitted
AhmarIftikhar123ā¢ 660@AhmarIftikhar123
Posted
Assalam u Alaikum,
I'm reviewing the webpage code and found a few areas that could be improved:
Reviewing webpage code: Missing responsive design: Consider implementing responsive design principles to ensure proper display across different devices. Cart functionality: Investigate why the cart box isn't appearing. Check if click events and state management are implemented correctly for the cart image. Notification issues: Verify the logic behind hiding message notifications. Ensure the number display updates correctly based on notifications. Missing button interactions: Consider adding hover classes to enhance user experience by providing visual feedback on button interaction. These are just pointers. Further analysis is needed based on the specific code and functionalities. I'm recently completed this challange:
https://github.com/AhmarIftikhar123/ecommerce-product-page-main0 - Comfortā¢ 310
@comfortprince
Submitted
AhmarIftikhar123ā¢ 660@AhmarIftikhar123
Posted
assalamoalaikum. for css hide scroll bar using ;;-webkit-scrollbar and set display to none. for js on displaying the final result use .tolocalestring method to format the text like 100000 to 100,000.
0 - Juan Galvezā¢ 50
@Galvez121
Submitted
Could anyone explain to me why the justify-content: center; and align-content: center; did not center the page? I had to use margin: auto; to do so. I could take those lines off, and It will not affect the page layout.
For the responsive, I was not sure how to change one picture to another one. I did it using display: none. Is there any other way to do that?
Any comment that would help me to improve is welcome!
AhmarIftikhar123ā¢ 660@AhmarIftikhar123
Posted
assalamoalaikum! set the height of container(body) to 100vh. for changing image at different seceen use picture tag inside it use source to change the image at different screen .also you can do this by js.
Css: body{ min-height:100vh; }
HTML: <picture> <source media="(min-width: 1024px)" srcset="large-image.jpg"> <source media="(min-width: 768px)" srcset="medium-image.jpg"> <img src="small-image.jpg" alt="A responsive image"> </picture>
1 - samrodssā¢ 90
@samrodss
Submitted
Any feedback is very welcome! I challenged myself to not use fixed units for width and height. However, the components did not look very much as I wanted, so I would really appreciate feedback on how to build more dynamic css
AhmarIftikhar123ā¢ 660@AhmarIftikhar123
Posted
Assalamoalaikum!"I hope you are fine.Everything in your code is fine just remove the footer of front end mentor that causes overflow on mobile devices in the case of your code.
Marked as helpful
0 - Burak Kƶstekliā¢ 510
@BurakKostekli
Submitted
all feedbacks are welcomed.
AhmarIftikhar123ā¢ 660@AhmarIftikhar123
Posted
Bro your code is really like a pro web dev. keep it up.I'm a beginner can you help me for improvment.
Marked as helpful
0
