Submitted
Abraham Oñate
@Abraham0216
All solutions
Submitted
I really hope you like it and if you have any suggestions for my code please share them I'd be glad. Responding to my question I just have two of them.
-When organizing the elements into the detail page it is clean enough?
-I'm not sure about the images on the home page for the flags, I decided that I wanted fixed dimensions, but this distorted the images, I applied an object cover but this trimmed the flags, and I don't know how to improve that part, I'd be glad if someone could helm me out with that.
Submitted
Hi guys! I've just finished this project and I used React and TailwindCSS, also used Formik and Yup for the form validation.
What would be the best practices you'd do with this project? Cause I'm not that sure if I implemented the best practices for step 1 of the form, could you tell me if everything is ok with that part of the code?
Submitted
Hi! I've finished this project, and I did it with ReactJS and TailwindJS. I used the states unconditionally to render one tab or another. Now I wonder, using React and Tailwind, is there any better approach than the one I did? Any advice or best practices that I didn't follow? I'd be so glad of learning from you.
Submitted
Hey guys! I've just finished this challenge. I used ReactJS and Tailwind. In this challenge, I also used MometsJS to work with the dates. It was hard to work with the dates at the start, but once I learned how to use MomentJS everything was easier. I'd like any feedback related to clean code or best practices. If you found some mistakes please let me know so I can fix them.
Submitted
Hi guys! I've just finished this challenge where I used React and TailwindCSS, I'd be glad of any feedback you could have. Here are some observations:
-
It's the first time I have used Tailwind for a project and I have a question, is it normal in Tailwind to repeat the classes for elements that you want to be the same style? Does that respect the DRY principle?
-
When closing the menu on the mobile version, it has a little bug that I tried to solve, but when I was fixing it end up creating other problems, so I decided to keep this solution, but if you have a better one or a different approach of the logic it uses, share, please! Here is the part of the code I think it's the problem with the Nav component
<ul className={`md:absolute z-0 p-4 md:flex md:w-5/12 md:flex-row md:justify-between ${menuOpen ? "fixed top-0 right-0 bg-white w-56 items-start px-4 h-screen flex flex-col gap-7 translate-x-0 ":"translate-x-full opacity-0 md:opacity-100"} ease-in-out duration-500 `}>
At last, no need to say that If you think that I could have done something better or cleaner please tell me, I'd appreciate :)
-
Submitted
Hi guys! I've just finished my first challenge on Frontend Mentors. I was wondering if something in my code was improvable. Do you consider it clean code? Is it uses the best practices?
I'd be so glad of receiving feedback :)