@SarkaeSubmitted about 2 years ago
Latest solutions
Latest comments
- @AbraCadabstraxPosted about 2 years ago
Hello. You pushed code and real artists ship. So take this as a win.
First, a note. "Responsive" is not the same thing as "responsible". Change up that title and have a good laugh, you learned something about the difference.
Now, as far as getting the responsive part set up. This is done largely through @media queries. A great place to start for this would be Kevin Powell's youtube video where he takes on this same challenge: https://www.youtube.com/watch?v=B2WL6KkqhLQ.
Good luck on your journey.
0 - @iamis15Submitted about 2 years ago@AbraCadabstraxPosted about 2 years ago
Hello, there is a broken link to the code source for your project. Now, this may be my issue as a user or you may have done something like delete the repository or change its name. Either way it makes it hard to provide useful feedback.
That said, the preview looked pretty good. So, if anything, the end result is ok.
Marked as helpful0 - @correlucasSubmitted over 2 years ago@AbraCadabstraxPosted about 2 years ago
Perhaps a bit trivial, but I would swap out the shopping cart emoji for the one provided with the assets for the project.
Otherwise very good job.
0 - @jchaparSubmitted over 2 years ago@AbraCadabstraxPosted over 2 years ago
Not much to say here, other than you did a great job. From what I can tell the outcome lines up with the spec and the code is clean. I checked it out for mobile and that seemed to work well too.
As far as the React code is concerned, I am not well versed in React so I can't comment much on that. I do think that it might be overkill for this particular project as the only moving part is the custom validator. Still, since it is one of your first React projects this was probably an easy way to get your feet wet.
Kudos!
Marked as helpful0
