learner11• 60
@b-kuhu
Submitted
Created QR component as my first challenge. I think I can improve more on CSS. Any feedback from your side will be appreciated. Thanks
Aashish
@AashishVivekBhat
All comments
- Aashish• 50
@AashishVivekBhat
Posted
Hello Kuhu, your solution is great. Some improvements that i can suggest :
-
Using relative units like rem, em instead of absolute units px while defining height, width, font-size etc. This may help in making it more responsive for different range of screens.
-
Element tags like
<main>, <h1>etc in your HTML may help in improving accessibility and semantics. -
You can also use MarkupValidationService to validate your HTML/CSS code.
Hope it was of some help, Happy learning.
0 -
