Skip to content
OverviewSolutions
38
Comments
8
ِAbdullah
@9dorgham

All comments

  • ِAbdullah•730
    @9dorghamPosted 8 months ago

    You've done awesome work.

    1. You didn't your design on mobile devices looks as it suppose to be does I'm talking here about the image.
    2. You used too much classes for your elements, what you don't need don't use don't just put classes everywhere for every element. You really did good effort on stylesheet. Have a nice day coding :)
    Marked as helpful
    1
  • Martin Mwaka•390
    @TemceoSubmitted 8 months ago
    What are you most proud of, and what would you do differently next time?

    I have sought to use semantic html

    What challenges did you encounter, and how did you overcome them?

    The biggest challenge was sizing and placing the image centrally. I overcame this by placing the image inside a div which enable me to control the size of the image and to control the div as a flex element.

    What specific areas of your project would you like help with?

    Any general points for improvement are welcome.

    social_links_profile_html_css

    1
    ِAbdullah•730
    @9dorghamPosted 8 months ago

    Good work everything looks good.

    1. You used the "<main>" element to contain your hole content and that's good, but it's a simple card you'd better use container elements like "<div>".
    2. Why you used this structure "<button class="btn github">GitHub</button>" it's an unorder list of links. We should use the correct elements for the correct purpose you could do this "<ul><li><a href="#">GitHub</a></li></ul>" .
    3. Use the "<strong>" element for important text like the address "London, United Kingdom" it will not just make it in bold it's important for search engines and assistive technologies like screen readers, you should read about it if you want to learn more. You've done awesome work, have a nice coding day :)
    Marked as helpful
    0
  • ِAbdullah•730
    @9dorghamPosted 8 months ago

    You've done awesome work. It's better to look at the figma file if it's available for you. If want to make your solution pixel perfect for example put the value for "width" and "height" properties as the design. things like these will make your solution better. Finally, have a nice day coding :)

    1
  • ِAbdullah•730
    @9dorghamPosted 8 months ago

    Good work. You should do more effort on styling choosing the correct colors for correct elements, I think you should use static width instead of 'relative units' like percentage. You can check the 'style-guide' file and check your fonts-type and size. lastly about your markup:

    1. you have an unordered list of links you can use "ul" element. In HTML you just need to choose the correct element for the correct purpose and probably you will get some accessibility features it's called "semantic elements". Have a nice coding day :)
    Marked as helpful
    0
  • Cheikh Sy•30
    @chkhsSubmitted 8 months ago
    What are you most proud of, and what would you do differently next time?

    I'm proud of being able to complete this project without following along on youtube. Next time I'd do things differently by coding this project in vite framework; challenging myself more and be able to grow from it.

    What challenges did you encounter, and how did you overcome them?

    Challenges I encountered was for CSS, width and height, padding. I had to do it just right otherwise it wouldnt even come close to looking like the original design.

    What specific areas of your project would you like help with?

    None at the moment.

    QR-Code Challenge

    1
    ِAbdullah•730
    @9dorghamPosted 8 months ago

    Good work. I have some suggestions for you:

    1. You embedded the font in your HTML file, so use it.
    2. Follow the style-guide to use colors in the correct place. Have a nice coding day :)
    Marked as helpful
    1
  • Mcnafaha•240
    @TheMcnafahaSubmitted 12 months ago

    What do you think of loading all country cards without waiting for their images to be loaded? Currently you see a grey background before the image loads. This means you can see the data of the cards without having to wait for the images to load, but you do the "flash" when the images do load.

    Adding an animation is something I'm considering adding, but is my current behavior ideal?

    MPA REST Countries API

    1
    ِAbdullah•730
    @9dorghamPosted 12 months ago

    You made and incredible effort keep going.

    1
  • ِAbdullah•730
    @9dorghamPosted about 1 year ago

    You forget the hover effect for the button .

    Marked as helpful
    0
  • ِAbdullah•730
    @9dorghamPosted almost 3 years ago

    I forget to say I added animation ,so you must click on "Preview Site" to see my solution. Thanks to come here and leave Feedback

    0