Design comparison
SolutionDesign
Community feedback
- @9dorghamPosted 8 months ago
Good work. You should do more effort on styling choosing the correct colors for correct elements, I think you should use static width instead of 'relative units' like percentage. You can check the 'style-guide' file and check your fonts-type and size. lastly about your markup:
- you have an unordered list of links you can use "ul" element. In HTML you just need to choose the correct element for the correct purpose and probably you will get some accessibility features it's called "semantic elements". Have a nice coding day :)
Marked as helpful0@Sujatha-17Posted 8 months ago@9dorgham thankyou so much for your informative feedback... will surely work on it..
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord