Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I have sought to use semantic html
What challenges did you encounter, and how did you overcome them?The biggest challenge was sizing and placing the image centrally. I overcame this by placing the image inside a div which enable me to control the size of the image and to control the div as a flex element.
What specific areas of your project would you like help with?Any general points for improvement are welcome.
Community feedback
- @9dorghamPosted 8 months ago
Good work everything looks good.
- You used the "<main>" element to contain your hole content and that's good, but it's a simple card you'd better use container elements like "<div>".
- Why you used this structure "<button class="btn github">GitHub</button>" it's an unorder list of links. We should use the correct elements for the correct purpose you could do this "<ul><li><a href="#">GitHub</a></li></ul>" .
- Use the "<strong>" element for important text like the address "London, United Kingdom" it will not just make it in bold it's important for search engines and assistive technologies like screen readers, you should read about it if you want to learn more. You've done awesome work, have a nice coding day :)
Marked as helpful0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord