Web Ninja 101 | URL shorten App w/ ES6 JS and Sass (and some BEM)

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Papa Elhadj Abdoulaye NDOYE! 👋

  Always nice to see you complete another challenge! I think you've done a great job on this one! 👏

  Everything looks good and responds very nicely! 👍

  The only tiny thing I might mention is to turn the mobile navigation icon into and close icon when the mobile navigation is opened for a slightly more intuitive UX. 😉

  Keep coding, of course (and happy coding, too)! 😁

  1

  ---

  

  Papa Elhadj Abdoulaye NDOYE•770

  @NDOY3M4NPosted almost 4 years ago

  @ApplePieGiraffe Thanks for the kind words and the feedbacks, I'll try adding some animations to the button.

  0
• 

  Papa Elhadj Abdoulaye NDOYE•770

  @NDOY3M4NPosted almost 4 years ago

  Oups, you're right. I totally forgot to change the hover styles on mobile. Thanks for the feedback

  1
• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted almost 4 years ago

  Hey @NDOY3M4N, project looks good, congrats! Only observed two things:

  • I think the header text could wait to increase its font size until it's ready to occupy 3 lines, past 900px or so. This way, it looks more proportional to the image.

  • The links on the mobile navbar blends with the color of the background when you hover on them.

  Hope this helps :-)

  1