Papa Elhadj Abdoulaye NDOYE

Latest comments

• 

  FREDERIK DIAMOND•70

  @FrederikDiamonDSubmitted over 2 years ago

  

  Order summary component with SCSS

  #sass/scss

  1

  80
  

  Papa Elhadj Abdoulaye NDOYE•770

  @NDOY3M4NPosted over 2 years ago

  Hi there. Great work on this challenge. I think you used the features (nesting mostly) correctly. Now there are some things in the design that you forgot.

  On mobile, because of the height: 100vh on the main the content is not showing properly. To fix this issue, you could replace that property with min-height: 100vh so that the main will only fill up the minimum space needed.

  You could also add some vertical padding on mobile.

  Happy coding 🎉️

  Marked as helpful

  1
• 

  wyliemickelson•290

  @wyliemickelsonSubmitted over 2 years ago

  

  Interactive Ecommerce Product Page

  #webpack#sass/scss

  1

  40
  

  Papa Elhadj Abdoulaye NDOYE•770

  @NDOY3M4NPosted over 2 years ago

  Wonderful 😍️😍️😍️.

  You just need to fix:

  • on 1366x750 screen, the modal is not showing properly (the close button is off the page), you could reduce the size of the carousel to accommodate for that.
  • on desktop, when hovering on the links the whole navbar is slightly moving. You could add the border with a transparent color on the default state, when in hover state you just change the color of the border.
  • you could also allow the users to open the navbar on mobile

  Happy coding 🎉️

  0
• 

  Matias•160

  @uspazSubmitted over 2 years ago

  

  Stats Preview Card (Scss - Responsive Design)

  #sass/scss

  2

  100
  

  Papa Elhadj Abdoulaye NDOYE•770

  @NDOY3M4NPosted over 2 years ago

  Nice job on this challenge. On mobile you could replace the height: 100vh to min-height: 100vh on the container class. You could also add some vertical padding on mobile. Other than that I think everything is okay. @Lucas feedback is also great. I use a similar technique when doing this challenge. Happy coding 🎉️

  Marked as helpful

  1
• 

  Michelle•150

  @mcdulingmSubmitted over 2 years ago

  

  Responsive Product Preview Card Component

  #sass/scss#bem

  1

  80
  

  Papa Elhadj Abdoulaye NDOYE•770

  @NDOY3M4NPosted over 2 years ago

  Hi, great work on this challenge. There are just some things that need fixing like:

  • on mobile the padding is not applied to the screen since you set height: 100vh on the main. You could fix this by just replacing it with min-height: 100vh.
  • on mobile you could also increase the padding (like in the design)
  • on line 37 (index.html) there is a typo, the closing tag should be a instead of button.

  Happy coding 🎉️

  Marked as helpful

  1
• 

  MJ•30

  @MJ1001Submitted over 3 years ago

  

  css flexbox, responsive design

  1

  20
  

  Papa Elhadj Abdoulaye NDOYE•770

  @NDOY3M4NPosted over 3 years ago

  You could add a max-width to the container class to sort-of constraint the width on mobile display. Great work

  1
• 

  imjackfrost1997•145

  @imjackfrost1997Submitted about 4 years ago

  

  Responsive landing page using HTML5, CSS3 and a little bit of JS

  1

  60
  

  Papa Elhadj Abdoulaye NDOYE•770

  @NDOY3M4NPosted about 4 years ago

  congrats, that's a super nice reproduction of the design. Keep at it!

  0