Design comparison
SolutionDesign
Solution retrospective
Trying to do these challenges as quickly as I can when I have time. Any feedback will be much appreciated. :)
Community feedback
- @NDOY3M4NPosted over 2 years ago
Hi, great work on this challenge. There are just some things that need fixing like:
- on mobile the padding is not applied to the screen since you set
height: 100vh
on the main. You could fix this by just replacing it withmin-height: 100vh
. - on mobile you could also increase the padding (like in the design)
- on line 37 (
index.html
) there is a typo, the closing tag should bea
instead ofbutton
.
Happy coding 🎉️
Marked as helpful1@mcdulingmPosted over 2 years ago@NDOY3M4N thanks for the feedback! It's nice to have someone double check stuff that can easily be overlooked. I truly appreciate it.
0 - on mobile the padding is not applied to the screen since you set
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord