Tip calculator. Built via vanilla javascript

Community feedback

• 

  Yacoub AlDweik•2,910

  @YacoubDweikPosted 5 months ago

  Good job

  Something very annoying is that I can't enter the bill value cuz I got always focus on the people value cuz it can't be zero so why don't you just put its value to 1 by default or at least git rid of that focus.

  another thing is that whenever I select a tip then I move to change the bill or the people my selection is gone.

  another thing in custom tip is that I can enter 100000000000 and nothing will stop me from doing that

  another thing is that the reset does not reset the values on that show box

  Marked as helpful

  1

  ---

  

  P

  Yulia•720

  @YuliaLantzbergPosted 5 months ago

  @YacoubDweik Hi. Thank you for your feedback. I agree with your first point, but it was the part of the task to keep the default value of people zero, so I did it in this way. Still, default 1 is more reasonable, so I changed it back. In my opinion, one should rethink the tip for different amounts or numbers of people, so I find it better to reset the tip. This calculator can be used in restaurant or by real estate agent or insurance, so I don't see the reason to ceil limit the sum. Thank you about pointing out on the reset bug. It is fixed.

  0
• 

  Vikas•170

  @gitVikas898Posted 5 months ago

  Nice work ! , I think the css needs to be fixed cause page looks a bit odd with a scroll bar + the border in in custom tip makes the ui bouncy try fixing that

  1

  ---

  

  P

  Yulia•720

  @YuliaLantzbergPosted 5 months ago

  @gitVikas898 Thank you. You are right. Fixed.

  0