Skip to content
Submitted almost 2 years ago

QR code component solution using Flexbox

ytsai4•20
@ytsai4
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • IryDev•1,580
    @IryDevPosted almost 2 years ago

    Hi @ytsai4 😄. Congratulation on successfully completing your first challenge on the platform ! !

    I have some recommendations in order to improve your solution :

    • Wrap the whole main content of your page into the semantic <main> tag.
    • Replace the <div class="attribution> by the semantic <footer> tag
    • Semantic html improve accessibility of your web page
    • Your page should have a <h1> tag that indicates a title or the main content of your website
    • Replace the <p class="title"> by the <h1>``` tag

    HTML :

    <body>
   <main>
        <div class="container">
        </div>
   </main>

   <footer class="attribution">
   </footer>
</body>

    I hope you'll find this helpful! 😄 Above all, your solution is really good!

    Marked as helpful
    0
    ytsai4•20
    @ytsai4Posted almost 2 years ago

    Hi@IryCode🙂. Thanks for your suggestion!

    I revised my solution by adding semantic tags. Accessibility report looks better now.

    0
    IryDev•1,580
    @IryDevPosted almost 2 years ago

    @ytsai4 No problem i'm glad it helped you

    0
  • Abdul Khaliq 🚀•72,360
    @0xabdulkhaliqPosted almost 2 years ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    COMPONENT MEASUREMENTS 📐:

    • Use min-height: 100vh for .container instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile phones in landscape mode.
    • For example; if we set height: 100vh then the .container will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.
    • But if we set min-height: 100vh then the .container will start at 100vh, if the content pushes the .container beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    0
  • Ecem Gokdogan•9,380
    @ecemgoPosted almost 2 years ago

    Some recommendations regarding your code that could be of interest to you.

    In order to fix the accessibility issues:

    • You need to replace <div class="container"> with the <main class="container"> tag and <div class="attribution"> with the <footer class="attribution"> tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly.
    • Each main content needs to include at least h1 element so you should use one <h1> element in the <main> tag. You can replace your <p class="title">Improve your frontend skills by buiding projects</p> element with the <h1 class="title">Improve your frontend skills by buiding projects</h1> element.

    After committing the changes on GitHub and you need to deploy it as a live site. Finally, you should click generate a new report on this solution page to clear the warnings.

    Hope I am helpful. :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord