All comments

• 

  Promil•10

  @promilmonuSubmitted over 1 year ago

  

  QR-Code using html css

  2

  40
  

  zohaib•80

  @zohaibAlam840Posted over 1 year ago

  Congrats on completing the challenge successfully! Your submission looks great on desktop size. However, it looks like you have optimized the solution specific to one size of browser width (desktop view) by using width: 20vw; I'd say such an approach could cause unwanted layout breaks for mobile view. A better practice would be to have a width: 100%, and a max-width: of 300px for the .result. However usually it is better to have these properties for the parent container and let the children derive their width from the parents width. E.g. parent could have max-width of 800px or 600px and set to display:flex, and children could have flex:1, so the parent container is divided into two equal columns.

  Hope this was helpful!

  Marked as helpful

  0