QR-Code using html css

Community feedback

• 

  zohaib•80

  @zohaibAlam840Posted over 1 year ago

  Congrats on completing the challenge successfully! Your submission looks great on desktop size. However, it looks like you have optimized the solution specific to one size of browser width (desktop view) by using width: 20vw; I'd say such an approach could cause unwanted layout breaks for mobile view. A better practice would be to have a width: 100%, and a max-width: of 300px for the .result. However usually it is better to have these properties for the parent container and let the children derive their width from the parents width. E.g. parent could have max-width of 800px or 600px and set to display:flex, and children could have flex:1, so the parent container is divided into two equal columns.

  Hope this was helpful!

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HEADINGS ⚠️:

  ---

  • And, This solution generates accessibility error reports due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  I hope you find this helpful ! 😄 Above all, the solution you submitted is great

  Happy coding!

  0