@FlackoCodes
Submitted
@yogskr
@FlackoCodes
Submitted
@yogskr
Posted
Heyo Joe, this is a cool landing page. Great job with the design!
I will only comment one thing about the font style though. It'd be great if you match the font size, the font's element length, and font alignment with the design.
Happy coding for other projects!
Marked as helpful
@FlackoCodes
Submitted
@yogskr
Posted
Hey Joe...let me give you feedback here.
Your landing page looks great. It's also great that you already implement the mobile-first design workflow.
Generally, my feedback is to re-touch some elements to match the design.
Also, I will only point out several things:
cursor: pointer
to the Try It Free button to make it look like an actual button. You can also use selector:hover
and apply some effects when you hover it.gap
or margin
to these containers: Grow Together, Flowing Conversations, and Your Users.Overall, your design looks great and as always, your code is easy to read. Keep this up, man!
Marked as helpful
@Aigooooo
Submitted
@yogskr
Posted
Hi, Aigooooo! Great job for completing the project.
That said, you could improve your code on several aspects:
<div class="container">
, you could use <main class="container">
.<h1>
instead of <h2>
for the Improve your front-end skills by building projects text.src
with the provided image in /images/image-qr-code.png
rather than using <img src="https://raw.githubusercontent.com/Aigooooo/frontend-mentor-io-qr-code/master/images/image-qr-code.png" alt="image-qr-code" />
.I hope the feedback can help you improve the code for this project. Keep it up and have a great one!
Marked as helpful
@Abdelsalam-03
Submitted
@yogskr
Posted
Hi, great job you have there to complete the challenge!
I have several suggestions for you:
<p>
tag.alt
text to the images will help improve the accessibility.I hope my suggestions help you in some way. Let's continue our journey!
Marked as helpful
@MyadVushka
Submitted
What is the best way to create the FAQ div in this case? Is it require to be position: absolute? Give please the best ways to create it and to create an accordion
@yogskr
Posted
Hey, the design looks great!
As for your question, I used position: relative
and set the top
to specific px
. Therefore, the container stays where it is as we apply the 'accordion' functionality.
Marked as helpful