Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Plain Html and CSS

Aigooooo 10

@Aigooooo

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Yoga 240

@yogskr

Posted

Hi, Aigooooo! Great job for completing the project.

That said, you could improve your code on several aspects:

  1. I recommend using semantic HTML structure. For example, instead of using <div class="container">, you could use <main class="container">.
  2. Still regarding semantic HTML, I would use <h1> instead of <h2> for the Improve your front-end skills by building projects text.
  3. I recommend changing the image src with the provided image in /images/image-qr-code.png rather than using <img src="https://raw.githubusercontent.com/Aigooooo/frontend-mentor-io-qr-code/master/images/image-qr-code.png" alt="image-qr-code" />.

I hope the feedback can help you improve the code for this project. Keep it up and have a great one!

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord